Skip to content
This repository was archived by the owner on Jan 5, 2018. It is now read-only.

Embed form converted to two-step form. - #23

Merged
slashrsm merged 8 commits into
drupal-media:ckeditor-integrationfrom
cs-shadow:two-step-form
Jun 4, 2014
Merged

Embed form converted to two-step form.#23
slashrsm merged 8 commits into
drupal-media:ckeditor-integrationfrom
cs-shadow:two-step-form

Conversation

@cs-shadow

Copy link
Copy Markdown
Member

File names have become little weird, so any suggestions are most welcome.

Comment thread js/plugins/entityembed/plugin.js Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better if we can move AjaxCommands in to separate JS files. I also suggested that in #22.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just do that. Having some troubles with libraries.yml. As soon as that is fixed, I'll move the AjaxCommands to a separate file.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AjaxCommands moved to separate JS file.

Comment thread js/plugins/entityembed/plugin.js Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think a little about how to make this steps configurable. Let's say that I want to completely swap out this step and replace it with something else (or even remove it entirely and just use some defaults). That should be possible and shouldn't allow much hacking with alters and stuff. Could we utilize plugins to achieve that?

This can be done as part of a follow-up issue.

slashrsm added a commit that referenced this pull request Jun 4, 2014
Embed form converted to two-step form.
@slashrsm
slashrsm merged commit 8266266 into drupal-media:ckeditor-integration Jun 4, 2014
@cs-shadow
cs-shadow deleted the two-step-form branch June 4, 2014 18:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants