Issue 2828510: Prevent installation of Commerce if bcmath PHP extensi… - #560
Merged
bojanz merged 2 commits intoNov 21, 2016
Merged
Conversation
Contributor
|
@mitrpaka this is true, however were you able to run |
Contributor
|
We're missing an ext-bcmath: "*" requirement in the composer.json, in addition to the code in this PR |
bojanz
requested changes
Nov 21, 2016
| if ($phase == 'install') { | ||
| if (!extension_loaded('bcmath')) { | ||
| $requirements['commerce'] = [ | ||
| 'description' => t("Commerce requires you to enable the following PHP extension: bcmath"), |
Contributor
There was a problem hiding this comment.
Wrong indentation for 'description' and 'severity'. The error message can be inside single quotes. The message should be 'Commerce requires the bcmath PHP extension.'
mglaman
force-pushed
the
feature/28282510-prevent_installation
branch
from
November 21, 2016 14:33
a31d95d to
46d00b0
Compare
Contributor
mglaman
force-pushed
the
feature/28282510-prevent_installation
branch
from
November 21, 2016 14:36
46d00b0 to
73826ea
Compare
bradjones1
pushed a commit
to bradjones1/commerce
that referenced
this pull request
May 4, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…on missing