chore: refresh stale test snapshots left over from #363 and #367#369
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainhad 7 committed Soroban test snapshots that no longer matched whatcargo testactually produces, in two batches:blend-adapter(accrue_is_idempotent_at_a_stable_rate,accrue_reflects_yield_from_a_rate_increase,deposit_supplies_to_pool_and_tracks_total,withdraw_after_accrue_pays_out_appreciated_value,withdraw_returns_usdc_and_reduces_total), left stale from fix: correct BlendAdapter.accrue() rate divisor #367: changing the mock pool'sSCALARconstant to match the realRATE_SCALARfix changed the recorded auth/footprint for every test sharing thatsetup(), not just the one new test added in that PR.defindex-adapter(get_pool_returns_the_configured_defindex_vault,get_protocol_returns_defindex), left stale since test: add unit tests for Blend and DeFindex adapter contracts #363: rewritingsetup()to addmint/set_admincalls for the new tests in that PR changed the fingerprint of the two pre-existing tests that share the same setup, which weren't re-committed at the time.git checkout -- <modified test_snapshots>cleanup step used to discard unrelated non-deterministic noise from earlier local runs also silently discarded these legitimately-changed files without checking each one individually.cargo test(matching CI's exact invocation,working-directory: packages/contracts,run: cargo test) twice independently, diffed every touched file againstmain, and confirmed the same 7 files show real, stable, non-trivial content drift both times — everything else is line-ending/generator-artifact noise from Windowscore.autocrlf, discarded.soroban-sdktestutils writes them after each run); nothing asserts against them, so this was never a CI-failing bug, just accumulating drift between what's committed and what the current code actually produces.Test plan
cargo testinpackages/contracts: 43 tests pass, snapshots now match exactlycargo clippy --all-targets -- -D warningsclean