Skip to content

test(sdk): cover keeper-tx status-code boundary and case-insensitivity - #702

Merged
collinsezedike merged 1 commit into
mainfrom
test/657-keeper-tx-edge-cases
Sep 2, 2026
Merged

test(sdk): cover keeper-tx status-code boundary and case-insensitivity#702
collinsezedike merged 1 commit into
mainfrom
test/657-keeper-tx-edge-cases

Conversation

@collinsezedike

Copy link
Copy Markdown
Collaborator

Summary

  • Closes [Test] keeper-tx.ts has no test file #657
  • packages/stellar-sdk-helpers/src/keeper-tx.test.ts already existed on main (a separate coverage PR landed it), but it was missing a few edge cases that matter for keeper retry correctness
  • Ports the missing assertions from test(sdk): cover keeper-tx error classification helpers #679 (closed as superseded, since it added a new file at the same path and conflicted): the status-code word-boundary guard, all five retryable status codes tested individually, case-insensitive keyword matching, and the distinction between a confirmed on-chain failure and a still-unknown timeout outcome
  • No production code changed

Test plan

  • pnpm --filter @meridian/stellar-sdk-helpers test -- keeper-tx.test.ts — 15 tests passing
  • prettier --check on the modified file — clean

@vercel

vercel Bot commented Sep 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
meridian Error Error Sep 1, 2026 9:15pm UTC

@collinsezedike
collinsezedike merged commit d07d6b9 into main Sep 2, 2026
9 of 10 checks passed
@collinsezedike
collinsezedike deleted the test/657-keeper-tx-edge-cases branch September 2, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Test] keeper-tx.ts has no test file

1 participant