Skip to content

feat(landing): add favicon and improve OG metadata#81

Merged
collinsezedike merged 4 commits into
drydocs:mainfrom
Aakriti0207:add-favicon-meta-tags
May 30, 2026
Merged

feat(landing): add favicon and improve OG metadata#81
collinsezedike merged 4 commits into
drydocs:mainfrom
Aakriti0207:add-favicon-meta-tags

Conversation

@Aakriti0207

Copy link
Copy Markdown
Contributor

Description

This PR improves the landing page social preview experience by completing missing metadata and adding favicon assets.

Changes Made

  • Added favicon assets:
    - favicon-32x32.png
    - favicon-180x180.png
  • Added favicon links in apps/landing/index.html
  • Added missing Open Graph metadata:
    - og:image
    - og:url
  • Added Twitter metadata for improved social sharing previews

Closes #49

Type of Change

  • feat — new feature
  • fix — bug fix
  • test — adding or improving tests
  • docs — documentation only
  • refactor — code restructuring without behaviour change
  • perf — performance improvement
  • chore — build, CI, or dependency update

Context (DeFi / Stellar)

Field Value
Network tested on N/A
Protocol affected None
Touches contracts? No
Wallet used N/A

Testing

Attempted local verification in GitHub Codespaces.

  • Verified favicon assets and metadata were added to apps/landing/index.html
  • Verified Open Graph and Twitter meta tags were added
  • Followed the suggested relative favicon path setup (./favicon-*)

Local testing note

I encountered an issue where the local Codespaces environment consistently redirected to /app, which made it difficult to fully verify favicon rendering for the landing page (apps/landing/) locally. Based on maintainer guidance, the favicon paths were updated to use relative references for compatibility with both local development and deployment.

Feedback or suggestions on local verification are very welcome.

Screenshots / Recordings (if applicable)

Favicon Added-

meridian favicon-noBg

Checklist

  • My branch follows the naming convention: feat/, fix/, docs/, chore/, refactor/, test/, or ci/
  • My commit messages follow Conventional Commits: type(scope): description
  • I have run pnpm lint && pnpm typecheck && pnpm test locally and all checks pass
  • I have added or updated tests where applicable
  • I have updated documentation where applicable
  • My changes do not introduce new console.log statements or commented-out code
  • I have not committed .env files, secrets, or private keys
  • For Soroban contract changes: I have run cargo clippy and cargo fmt --all

@vercel

vercel Bot commented May 29, 2026

Copy link
Copy Markdown

@Aakriti0207 is attempting to deploy a commit to the Collins' projects Team on Vercel.

A member of the Team first needs to authorize it.

Comment thread apps/landing/favicon-32x32.png
Comment thread apps/landing/index.html Outdated
@vercel

vercel Bot commented May 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
meridian Ready Ready Preview, Comment May 30, 2026 10:01am

@collinsezedike

Copy link
Copy Markdown
Collaborator

Hey @Aakriti0207, could you enable "Allow edits from maintainers" on this PR? There's a small fix needed in the build script to get the favicons rendering on the deployment and it'll be faster for me to apply it directly.

@Aakriti0207

Copy link
Copy Markdown
Contributor Author

Hey @Aakriti0207, could you enable "Allow edits from maintainers" on this PR? There's a small fix needed in the build script to get the favicons rendering on the deployment and it'll be faster for me to apply it directly.

Thanks for pointing this out! I’ve now re-exported the favicon assets at the correct dimensions (32×32 and 180×180) and optimized/compressed them to significantly reduce file size for better performance.
Now -
file size for 32x32 : 1.23KB
and for 180x180: 31.0KB
Please let me know if further optimisations are needed

@Aakriti0207

Copy link
Copy Markdown
Contributor Author

Hey @Aakriti0207, could you enable "Allow edits from maintainers" on this PR? There's a small fix needed in the build script to get the favicons rendering on the deployment and it'll be faster for me to apply it directly.

Hi! “Allow edits from maintainers” is already enabled on the PR from my end...
image
I have tried and addressed other issues as well - please let me know if any more changes are needed
Thanks!

@collinsezedike

Copy link
Copy Markdown
Collaborator

Check this out!
Screenshot (1)

@collinsezedike

Copy link
Copy Markdown
Collaborator

Brilliant work, @Aakriti0207

Feel free to pick any other open issues if you'd like to keep contributing,
Would love if you could scratch off #52 for me.

Merging now!

@collinsezedike collinsezedike merged commit 7d0164c into drydocs:main May 30, 2026
4 checks passed
@Aakriti0207

Copy link
Copy Markdown
Contributor Author

Thank you so much @collinsezedike , really appreciate it, I genuinely learned a lot through the review process.

I’d definitely love to contribute more- I’ll take a look at #52 definitely (in like 4-5 days though- exams 😭)
Thanks again for all the guidance along the way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Frontend] Add favicon and Open Graph meta tags to landing page

2 participants