FileSystemAccessRule: No longer tries to write back owner from the ACL#4
Merged
johlju merged 7 commits intodsccommunity:masterfrom Apr 19, 2020
bendwyer:bendwyer-patch-filesystemaccessrule
Merged
FileSystemAccessRule: No longer tries to write back owner from the ACL#4johlju merged 7 commits intodsccommunity:masterfrom bendwyer:bendwyer-patch-filesystemaccessrule
johlju merged 7 commits intodsccommunity:masterfrom
bendwyer:bendwyer-patch-filesystemaccessrule
Conversation
Member
|
It might not be until this weekend I can look a this and help with the tests. Great work! 🙂 |
Member
|
I'm on this now. |
johlju
added
waiting for code fix
johlju
added
needs review
johlju
approved these changes
Apr 19, 2020
Member
johlju
left a comment
johlju
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, 1 of 1 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
johlju
added
ready for merge
johlju
changed the title
johlju
approved these changes
Apr 19, 2020
Member
johlju
left a comment
johlju
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4.
Reviewable status:
johlju
removed
the
ready for merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My attempt to fix #3 .
Added code from https://github.com/dsccommunity/xSystemSecurity/pull/14/files.
Did not update the corresponding
Get-Aclreferences in the Notes sections.This change is