Skip to content

busybox-build-guards-v2

busybox-build-guards-v2: [PATCH v2 0/2] (Re-)instate some build guards
@dscho dscho tagged this 14 Jul 20:25 
It would appear that some compile-time flags are used as if they were
runtime flags, i.e. they are used in if (...) constructs, not in
`#if ... #endif` guards.

The effect *should* be the same, except when switching off optimization
(e.g. for debugging) where dead code is not removed, possibly leading to
build errors where features are disabled because the required functions
are unavailable.

Changes since v1:

- enclosed also the `jobless--;` statement in the #if JOBS ... #endif that
  clearly was part of the `if()` already inside that clause.

- skipped 2/3, as it was already applied as 7d7c7bb22 (libbb: hide
  getnetbyaddr() inside "#if ENABLE_FEATURE_ETC_NETWORKS" block,
  2017-07-14) (silently dropping my authorship, and smooshing it
  together with plenty of `#if DEBUG bb_error_msg(...) #endif` =>
  `dbg(...)` conversions, making it hard to see the functional change)

Johannes Schindelin (2):
  copyfd: reinstate proper guard around munmap()
  ash: use JOBS as the compile time option it actually is

 libbb/copyfd.c |  2 ++
 shell/ash.c    | 12 +++++++++---
 2 files changed, 11 insertions(+), 3 deletions(-)

base-commit: 7d7c7bb2205b92359ac88f3469d3af672e2be929

Submitted-As: https://public-inbox.org/git/null
Assets 2
Loading