Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add interface and type literal getters & setters #1473

Merged
merged 7 commits into from Dec 2, 2023

Conversation

ajvincent
Copy link
Contributor

@ajvincent ajvincent commented Nov 23, 2023

This isn't finished. It compiles, but per directive, I'm creating a pull request as a snapshot.

Closes #1431

@ajvincent
Copy link
Contributor Author

ajvincent commented Nov 23, 2023

See #1431

@dsherret dsherret changed the title Interface getters and setters feat: add interface and type literal getters & setters Dec 2, 2023
Copy link
Owner

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ajvincent! This looks good to land now.

@dsherret dsherret merged commit 339f685 into dsherret:latest Dec 2, 2023
1 check passed
diegohaz pushed a commit to ariakit/ariakit that referenced this pull request Dec 2, 2023
[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ts-morph](https://togithub.com/dsherret/ts-morph) | [`20.0.0` ->
`21.0.0`](https://renovatebot.com/diffs/npm/ts-morph/20.0.0/21.0.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/ts-morph/21.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/ts-morph/21.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/ts-morph/20.0.0/21.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/ts-morph/20.0.0/21.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>dsherret/ts-morph (ts-morph)</summary>

###
[`v21.0.0`](https://togithub.com/dsherret/ts-morph/releases/tag/21.0.0)

[Compare
Source](https://togithub.com/dsherret/ts-morph/compare/20.0.0...21.0.0)

#### What's Changed

- feat: `ProjectOptions::defaultCompilerOptions` by
[@&#8203;wojpawlik](https://togithub.com/wojpawlik) in
[dsherret/ts-morph#1460
- feat: TypeScript 5.3
[dsherret/ts-morph#1476
- feat: add interface and type literal getters & setters by
[@&#8203;ajvincent](https://togithub.com/ajvincent) in
[dsherret/ts-morph#1473
- feat: add wrapped method for `getShorthandAssignmentValueSymbol` to
`TypeChecker`. add convenience method for getting the value symbol on
`ShorthandPropertyAssignment`. by
[@&#8203;kronodeus](https://togithub.com/kronodeus) in
[dsherret/ts-morph#1456
- perf: use path.exists functions that don't throw internally when not
exists
[dsherret/ts-morph#1478

##### Breaking Changes

-   Upgraded to TS 5.3
- Underlying `@ts-morph/common` file system methods return undefined
instead of throwing when not exists (for perf).
- Private fields are actually private (default build requires private
fields).

#### New Contributors

- [@&#8203;ajvincent](https://togithub.com/ajvincent) made their first
contribution in
[dsherret/ts-morph#1473

**Full Changelog**:
dsherret/ts-morph@20.0.0...21.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ariakit/ariakit).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@ajvincent ajvincent deleted the interface-getters-setters branch December 2, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InterfaceDeclarationStructure has no get or set accessors
2 participants