fix: merge batch summaries so narrative appears on multi-batch PRs - #16
Merged
Conversation
_merge_results() collected findings, usage, and fix_verifications from each batch but silently dropped the summary field. Single-batch PRs preserved it end-to-end while multi-batch PRs (large PRs) always lost it, causing the Overall Summary section to be missing from the PR comment. Also make summary required in findings-schema.json so the agent always produces one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@
Summary
_merge_results()inBatchReviewJobcollected findings, usage, and fix_verifications from each batch but silently dropped thesummaryfield — multi-batch PRs (large PRs like PR 5703 with 315 files) never showed the📝 Overall Summarysection while single-batch PRs (like PR 6598) didsummaryis now required infindings-schema.jsonso the agent always produces oneTest plan
@