fix(scoring): rework penalties, conditional migration mode, cr-id rendering - #21
Merged
Conversation
…cr-id rendering - Add penalties for code_style (1.0/0.5/0.25), documentation (1.0/0.5/0.25), and testing (1.5/0.75/0.25) — previously all zero - Bump architecture penalties to match performance tier (3.0/2.0/1.0) - Make migration mode conditional — only activate for PRs with migration files - Exempt code_style, documentation, testing from migration mode escalation - Move cr-id markers from HTML comments to ADO thread properties to fix intermittent rendering of <!-- cr-id --> as visible text - Remove <!-- codehawk-summary --> marker from summary body, use property instead - Backward compat: fetch still falls back to comment text parsing for old threads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
code_style(1.0/0.5/0.25),documentation(1.0/0.5/0.25), andtesting(1.5/0.75/0.25) — previously all zero so these categories had no impact on PR score. Bumpedarchitecturepenalties to matchperformancetier (3.0/2.0/1.0).code_style,documentation, andtestingfrom escalation to critical — an unused import is not a migration risk.<!-- cr-id: xxx -->markers from comment body text to ADO thread properties (CodeHawk.CrId). Azure DevOps inconsistently renders HTML comments as visible text, causing<!-- cr-id: cr-004 -->to show in PR comments. Thread properties are metadata-only and never rendered. Backward compatible — fetch still falls back to comment text parsing for old threads.Test plan
test_migration_mode_skips_zero_penalty_categoriestest_code_style_has_light_penalty(wastest_code_style_has_zero_penalty)