Skip to content

Fix use all available runpod regions by default #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r4victor merged 5 commits into from
Oct 3, 2024
Merged

Fix use all available runpod regions by default #1757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c831423
Fix Handle KeyboardInterrupt in CLI when getting run plan #1626
Oct 1, 2024
9e4bb23
Allow using all existing regions unless a specific set of regions is …
Oct 1, 2024
0e6a938
Delete src/dstack/_internal/cli/commands/apply.py
IshuSinghSE Oct 1, 2024
1cd4641
Revert "Delete src/dstack/_internal/cli/commands/apply.py"
Oct 1, 2024
6bc2fca
Fix use all available runpod regions by default
Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 27 additions & 23 deletions src/dstack/_internal/cli/commands/apply.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,27 +50,31 @@ def _register(self):
)

def _command(self, args: argparse.Namespace):
if args.help is not NOTSET:
if args.help is not None:
configurator_class = get_apply_configurator_class(
ApplyConfigurationType(args.help)
)
else:
configurator_class = BaseApplyConfigurator
configurator_class.register_args(self._parser)
self._parser.print_help()
return
try:
if args.help is not NOTSET:
if args.help is not None:
configurator_class = get_apply_configurator_class(
ApplyConfigurationType(args.help)
)
else:
configurator_class = BaseApplyConfigurator
configurator_class.register_args(self._parser)
self._parser.print_help()
return

super()._command(args)
configuration_path, configuration = load_apply_configuration(args.configuration_file)
configurator_class = get_apply_configurator_class(configuration.type)
configurator = configurator_class(api_client=self.api)
configurator_parser = configurator.get_parser()
known, unknown = configurator_parser.parse_known_args(args.unknown)
configurator.apply_configuration(
conf=configuration,
configuration_path=configuration_path,
command_args=args,
configurator_args=known,
unknown_args=unknown,
)
super()._command(args)
configuration_path, configuration = load_apply_configuration(args.configuration_file)
configurator_class = get_apply_configurator_class(configuration.type)
configurator = configurator_class(api_client=self.api)
configurator_parser = configurator.get_parser()
known, unknown = configurator_parser.parse_known_args(args.unknown)
configurator.apply_configuration(
conf=configuration,
configuration_path=configuration_path,
command_args=args,
configurator_args=known,
unknown_args=unknown,
)
except KeyboardInterrupt:
print("\nOperation interrupted by user. Exiting...")
exit(0)
8 changes: 7 additions & 1 deletion src/dstack/_internal/server/services/backends/configurators/runpod.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,19 @@

REGIONS = [
"CA-MTL-1",
"CA-MTL-2",
"CA-MTL-3",
"EU-NL-1",
"EU-RO-1",
"EU-SE-1",
"EUR-IS-1",
"EUR-IS-2",
"EUR-NO-1",
"US-CA-1",
"US-GA-1",
"US-GA-2",
"US-KS-2",
"US-OR-1",
"US-TX-3",
]

DEFAULT_REGION = "CA-MTL-1"
Expand Down