Many minor improvements to docs and examples#2013
Merged
peterschmidt85 merged 2 commits intomasterfrom Nov 20, 2024
Merged
Conversation
- [Docs/Examples] Updated service instructions - [Examples] Deleted some outdated examples (QLoRA, Mixtral, TEI) - [Examples] Updated TPU/AMD examples structure to make it a bit simpler - [Examples] If only one config in the folder, using `.dstack.yml` file notation - [Examples] Renamed build configurations file names (AMD) - [Examples] Replaced Ollama with NIM in Llama 3.1 - [Docs] Updated Protips (simplifies Tasks vs. Services)
jvstme
approved these changes
Nov 20, 2024
docs/docs/guides/protips.md
Outdated
Comment on lines
103
to
108
| !!! info "Gateway" | ||
| To enable [auto-scaling](reference/dstack.yml/service.md#auto-scaling), or use a custom domain with HTTPS, | ||
| set up a [gateway](concepts/gateways.md) before running the service. | ||
| If you're using [dstack Sky :material-arrow-top-right-thin:{ .external }](https://sky.dstack.ai){:target="_blank"}, | ||
| a gateway is pre-configured for you. | ||
|
|
Collaborator
There was a problem hiding this comment.
(nit) Considering the text above no longer describes services, mentioning gateways looks irrelevant
Suggested change
| !!! info "Gateway" | |
| To enable [auto-scaling](reference/dstack.yml/service.md#auto-scaling), or use a custom domain with HTTPS, | |
| set up a [gateway](concepts/gateways.md) before running the service. | |
| If you're using [dstack Sky :material-arrow-top-right-thin:{ .external }](https://sky.dstack.ai){:target="_blank"}, | |
| a gateway is pre-configured for you. |
superprat
pushed a commit
to bahaal-tech/dstack
that referenced
this pull request
Dec 20, 2024
* - [Examples] Deleted dev environment configs - [Docs/Examples] Updated service instructions - [Examples] Deleted some outdated examples (QLoRA, Mixtral, TEI) - [Examples] Updated TPU/AMD examples structure to make it a bit simpler - [Examples] If only one config in the folder, using `.dstack.yml` file notation - [Examples] Renamed build configurations file names (AMD) - [Examples] Replaced Ollama with NIM in Llama 3.1 - [Docs] Updated Protips (simplifies Tasks vs. Services) * - [Docs] Addressing review feedback by @jvstme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.dstack.ymlfile notation