Skip to content

Feature 534 wind rose - #535

Merged
bikegeek merged 4 commits into
developfrom
feature_534_wind_rose
Aug 11, 2025
Merged

Feature 534 wind rose#535
bikegeek merged 4 commits into
developfrom
feature_534_wind_rose

Conversation

@bikegeek

@bikegeek bikegeek commented Aug 4, 2025

Copy link
Copy Markdown
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

using the test data and config file for the wind rose, modify values for the radialaxis_step and radialaxis_range. Also omit the radialaxis_range and verify a plot is still generated using Plotly's ranges.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    generate plots using relevant data

Config file used in testing:
wind_rose_custom.yaml.txt

to generate this plot:

wind_rose_custom
  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]

  • Do these changes include sufficient testing updates? [NA]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [Yes]

    If yes, please describe:
    SonarQube gate check will fail due to coverage value that falls below threshold value.

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@bikegeek
bikegeek requested a review from CPKalb August 4, 2025 19:12
@github-project-automation github-project-automation Bot moved this to 🩺 Needs Triage in METplus-6.2 Development Aug 4, 2025
@bikegeek bikegeek moved this from 🩺 Needs Triage to 🟢 Ready in METplus-6.2 Development Aug 4, 2025
@bikegeek bikegeek linked an issue Aug 5, 2025 that may be closed by this pull request
23 tasks
@JohnHalleyGotway JohnHalleyGotway moved this from 🟢 Ready to 🔎 In review in METplus-6.2 Development Aug 5, 2025
@JohnHalleyGotway JohnHalleyGotway added this to the METplotpy-3.2.0 milestone Aug 5, 2025
@bikegeek bikegeek moved this from 🔎 In review to 🟢 Ready in METplus-6.2 Development Aug 5, 2025
@CPKalb

CPKalb commented Aug 9, 2025

Copy link
Copy Markdown
Contributor

I'm unclear exactly how the settings in the yaml file are supposed to work and so wanted to verify here. If I set the following:
radialaxis_range: [0, 15]
radialaxis_step: 5

then I get the wind rose below with 0, 5, 10, and 15% labeled as expected.
Screenshot 2025-08-08 at 6 10 47 PM

However, if I instead set the following:
radialaxis_range: [0, 15]
radialaxis_step: 3

then I get the wind rose below with 2, 5, 8, 11, and 14% labeled.
Screenshot 2025-08-08 at 8 03 23 PM

In this second case, I was expecting 0, 3, 6, 9, 12, 15%. What is the expected behavior for this second image?

…to ensure the step between axes is consistent with what is set in radialaxis_step
@bikegeek

bikegeek commented Aug 10, 2025

Copy link
Copy Markdown
Collaborator Author

I explicitly set dtick0 to the first value in the radialaxis_range and now the plot looks like this when I set the step size to 3:

#  Uncomment to specify the range of the radial axes to draw
radialaxis_range: [0, 15]

# Step size in between ticks of the axis
radialaxis_step: 3
wind_rose_custom

@bikegeek

Copy link
Copy Markdown
Collaborator Author

I looked through the Plotly documentation for polar and polar bar plots and cannot get the last radial line drawn!

@CPKalb

CPKalb commented Aug 11, 2025

Copy link
Copy Markdown
Contributor

I explicitly set dtick0 to the first value in the radialaxis_range and now the plot looks like this when I set the step size to 3:

#  Uncomment to specify the range of the radial axes to draw
radialaxis_range: [0, 15]

# Step size in between ticks of the axis
radialaxis_step: 3
wind_rose_custom

Is this a change I need to make somewhere (set dtick0 to 0)?

@CPKalb CPKalb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my data and works as expected, now having the ability to specify the range of the radial axes.

@bikegeek

bikegeek commented Aug 11, 2025 via email

Copy link
Copy Markdown
Collaborator Author

@bikegeek bikegeek moved this from 🟢 Ready to 🔎 In review in METplus-6.2 Development Aug 11, 2025
@bikegeek
bikegeek merged commit 1b74d13 into develop Aug 11, 2025
6 of 7 checks passed
@github-project-automation github-project-automation Bot moved this from 🔎 In review to 🏁 Done in METplus-6.2 Development Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: 🏁 Done

Development

Successfully merging this pull request may close these issues.

Wind Rose: support specifying range radialaxes range

3 participants