Sync embedding delay#294
Conversation
📝 WalkthroughWalkthroughAdded a 600-second pause to the CI/CD workflow after identifying changed MDX files, allowing deployment to complete before re-embedding articles. Updated image alt text in documentation by adding a trailing period for consistency. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/sync-embeddings.yml (1)
27-30: Make deploy wait configurable instead of hard-coding 600 seconds.This works, but hard-coding the delay makes operational tuning slower and forces code changes for every adjustment.
♻️ Suggested tweak
- name: Wait for Mintlify to deploy if: steps.changed.outputs.files != '' - run: sleep 600 + env: + MINTLIFY_DEPLOY_WAIT_SECONDS: 600 + run: | + echo "Waiting ${MINTLIFY_DEPLOY_WAIT_SECONDS}s for Mintlify deploy..." + sleep "${MINTLIFY_DEPLOY_WAIT_SECONDS}"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/sync-embeddings.yml around lines 27 - 30, Replace the hard-coded sleep 600 in the "Wait for Mintlify to deploy" step with a configurable environment/input variable (e.g., DEPLOY_WAIT) and use a shell fallback so operators can override without code changes; for example, add an env or workflow input named DEPLOY_WAIT with default 600 and change the step's run to use bash fallback like sleep "${{ env.DEPLOY_WAIT:-600 }}" (keep the existing if: steps.changed.outputs.files != '' condition).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/sync-embeddings.yml:
- Around line 27-30: Replace the hard-coded sleep 600 in the "Wait for Mintlify
to deploy" step with a configurable environment/input variable (e.g.,
DEPLOY_WAIT) and use a shell fallback so operators can override without code
changes; for example, add an env or workflow input named DEPLOY_WAIT with
default 600 and change the step's run to use bash fallback like sleep "${{
env.DEPLOY_WAIT:-600 }}" (keep the existing if: steps.changed.outputs.files !=
'' condition).
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2b14f5bb-76c7-405f-a022-8c321def4da3
📒 Files selected for processing (2)
.github/workflows/sync-embeddings.ymlhelp/article/partner-rewards.mdx
Summary by CodeRabbit
Documentation
Chores