Skip to content

remove sync-embedding sleep from actions and add it to api#297

Merged
steven-tey merged 1 commit intomainfrom
sync-embeddings-sleep
Mar 6, 2026
Merged

remove sync-embedding sleep from actions and add it to api#297
steven-tey merged 1 commit intomainfrom
sync-embeddings-sleep

Conversation

@pepeladeira
Copy link
Copy Markdown
Collaborator

@pepeladeira pepeladeira commented Mar 6, 2026

Summary by CodeRabbit

  • Chores
    • Optimized embedding synchronization workflow by streamlining the deployment process and adjusting timing parameters for improved performance.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 200d48fe-32ee-475f-9b0d-c32b81268e99

📥 Commits

Reviewing files that changed from the base of the PR and between 1e12419 and 10955d6.

📒 Files selected for processing (1)
  • .github/workflows/sync-embeddings.yml

📝 Walkthrough

Walkthrough

The GitHub Actions workflow for syncing embeddings is updated to remove an explicit wait step and instead pass a 600-second delay parameter directly in the embedding API request payload.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/sync-embeddings.yml
Removed "Wait for Mintlify to deploy" step and added "delay": 600 field to the embedding POST request payload, consolidating delay handling into the API call itself.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • Sync embedding delay #294: Introduces a complementary 600-second delay mechanism by adding a sleep step; this PR moves to an in-payload delay approach instead.

Suggested reviewers

  • steven-tey

Poem

🐰 The workflow hops with purpose bright,
No more waiting in the night,
Delay embedded in the call,
Simplified for one and all! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing a sleep step from the GitHub Actions workflow and adding a delay parameter to the API request instead.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sync-embeddings-sleep

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pepeladeira pepeladeira marked this pull request as ready for review March 6, 2026 21:18
@steven-tey steven-tey merged commit 3adf573 into main Mar 6, 2026
4 checks passed
@steven-tey steven-tey deleted the sync-embeddings-sleep branch March 6, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants