fix: include catalog.hpp directly in pyconnection.cpp#541
Open
NickCrews wants to merge 1 commit into
Open
Conversation
pyconnection.cpp uses Catalog::GetCatalog/GetSystemCatalog but relied on a transitive include of duckdb/catalog/catalog.hpp via function/table_function.hpp -> execution/physical_operator_states.hpp. duckdb main removed that include chain (~2026-07-10), so PR and nightly CI - which build against duckdb main via the duckdb-sha override - fail to compile with "incomplete type 'duckdb::Catalog'". Include the header directly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
Looks like CI still fails during the testing phase for unrelated reasons, but at least we can even build it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One-line fix: add
#include "duckdb/catalog/catalog.hpp"tosrc/pyconnection.cpp.Why
pyconnection.cppusesCatalog::GetCatalog/Catalog::GetSystemCatalogbut relied on a transitive include ofcatalog.hppviafunction/table_function.hpp→execution/physical_operator_states.hpp. duckdb main removed that include chain (~2026-07-10).PR and nightly CI build against duckdb main (
duckdb-sha: ${{ github.base_ref }}inon_pr.yml), so every PR currently fails with:(e.g. #409 and main's own Release runs). Builds against the pinned submodule (3a3c412) are unaffected, which is why this doesn't reproduce locally.
Verification
Compiled
pyconnection.cpplocally against both duckdb main (2009475939) and the pinned submodule: error reproduces on duckdb main without this change, compiles cleanly with it on both.🤖 Generated with Claude Code