Open
Conversation
- Created UCTableCredentialManager singleton class to centralize AWS temp credentials caching logic - Removed ~70 lines of duplicated code between uc_catalog.cpp and uc_table_entry.cpp - Replaced global variables (table_secret_mutexes, mutex_map_mutex, secret_expiration_times) with private members of credential manager - Extracted magic number (5 minutes) into named constant REFRESH_SAFETY_MARGIN_MS - Fixed secret_caching.test to attach catalog with DEFAULT_SCHEMA and correct expected results This addresses PR feedback about code duplication and global variable usage.
liko9
added a commit
to liko9/unity_catalog
that referenced
this pull request
Jan 29, 2026
Adds UCTableCredentialManager to cache temporary credentials for Unity Catalog tables, reducing API calls and improving performance. Includes thread-safe credential refresh with expiration checking. Resolved conflicts with time travel support changes from PR duckdb#67. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
liko9
added a commit
to liko9/unity_catalog
that referenced
this pull request
Jan 29, 2026
Synced with upstream PR duckdb#70 (step up to v1.5-variegata). Resolved conflicts in unity_catalog.cpp - kept credential_manager from PR duckdb#63. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small tweaks to original PR: #58 by @UriSaShavit
Reopened because i can't push directly to that one, and our current test suite is not super external-contributor friendly since we can't really test this in the local minio right now