Merged
Conversation
samansmink
approved these changes
Jan 15, 2026
Collaborator
|
amazing, thanks @Tishj! |
liko9
added a commit
to liko9/unity_catalog
that referenced
this pull request
Jan 29, 2026
Adds UCTableCredentialManager to cache temporary credentials for Unity Catalog tables, reducing API calls and improving performance. Includes thread-safe credential refresh with expiration checking. Resolved conflicts with time travel support changes from PR duckdb#67. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the use of the
AT (VERSION => <numeric version>)clause for a table scan.Summary of Changes
UCCatalogSetandUCInSchemaSet(stripped back the abstraction).UCTableEntry::GetScanFunctionproperly delegate to the wrapped catalog.OnDetachoverride to detach the nested catalogs (the delta catalogs)TableInformationinbetween theUCTableSetand theUCTableEntry[1].[1] This is necessary because the
TableCatalogEntryhascolumns, which informs the table scan which columns exist.Which requires us to make a
TableCatalogEntryfor each schema version. This is why theTableInformationhas aGetVersionmethod to use the at clause to determine which entry to return.