Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
GerardPaligot
approved these changes
Feb 12, 2026
Contributor
GerardPaligot
left a comment
There was a problem hiding this comment.
LGTM, but the build is failing due to lint errors from our new rule regarding impl module usage within the app module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/task/1213242498673303
Description
Steps to test this PR
QA-optional
No UI changes
Note
Low Risk
Test-only migration with lint-baseline churn; minimal production impact, but there’s some risk of behavior drift due to Robolectric vs device/runtime differences.
Overview
Migrates
BrowserTabViewModelTestandBrowserWebViewClientTestfrom instrumentation (androidTest) to Robolectric/JVM (test) by switching toAndroidJUnit4+@Config(sdk = [34]), replacingInstrumentationRegistryusage withRuntimeEnvironment, and dropping@UiThreadTest/@SdkSuppressgating.Adds a reusable
ValueCaptorObservertest helper, and adjusts test setup to better match Robolectric behavior (e.g., explicitly populatingMimeTypeMapmappings and makingTestWebViewreportprogress=100). The lint baseline is updated to reflect moved test file paths and to remove prior denylisted-API entries tied to the old instrumentation tests.Written by Cursor Bugbot for commit cdfc264. This will update automatically on new commits. Configure here.