Onboarding Brand Design Update: Add in-context Site Suggestions dialog v2#8564
Merged
mikescamell merged 4 commits intoMay 14, 2026
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b7e3dc9. Configure here.
…xtual dialog Populate the Stage-1 stub with options binding (onboardingStore.getSitesOptions) and the options-variant content layout, replace sentinels across CtaViewModel and BrowserTabViewModel, and add the per-dialog unit test.
8 WebP variants (4 densities × light/dark) at 90% quality.
CtaViewModel gained this constructor dependency on develop. Adds the mock to DaxSiteSuggestionsBrandDesignUpdateContextualCtaTest to fix the broken unit test compilation on this branch.
mikescamell
force-pushed
the
feature/mike/onboarding-brand-design-updates/contextual-site-suggestions
branch
from
b7e3dc9 to
f7e78f8
Compare
aibrahim-
approved these changes
May 14, 2026
mikescamell
deleted the
feature/mike/onboarding-brand-design-updates/contextual-site-suggestions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/task/1212699268790181
Was removed from develop.
See #8483 for description and details
Note
Medium Risk
Updates onboarding CTA selection and renders a new in-context site-suggestions dialog, which could affect onboarding flow and CTA telemetry if view wiring or toggles behave unexpectedly.
Overview
Switches the brand-design onboarding path for the site suggestions dialog to return
DaxSiteSuggestionsBrandDesignUpdateContextualCta(instead of the legacyDaxSiteSuggestionsCta) and wires it into the browser query handling so custom visit-site pixels still fire.Implements the previously-stubbed
DaxSiteSuggestionsBrandDesignUpdateContextualCtaUI (layout include, background, title/description, 4 option buttons, and click callbacks viasetOnOptionClicked) and adds a test ensuring the brand-design toggle returns the new CTA and thatshown/ok/dismisspixels continue to fire with the expected params.Reviewed by Cursor Bugbot for commit f7e78f8. Bugbot is set up for automated code reviews on this repo. Configure here.