Onboarding Brand Design Update: Add in-context Site Suggestions dialog

[mikescamell]

Task/Issue URL: https://app.asana.com/1/137249556945/task/1212699268790181

Description

Migrates the Site Suggestions contextual onboarding dialog to the new brand-design layout introduced in #8439, gated behind the onboardingBrandDesignUpdate feature flag.

With the flag on:

• Site Suggestions CTA renders in the new card chrome with title and body as distinct blocks.
• Adds the SiteSuggestions CTA background banner asset and wires it to the slide-up / slide-out animation pipeline introduced in Onboarding Brand Design Update: Add in-context SERP dialog #8439 — slides up from behind the card on appear, slides out on dismiss / content swap.

Out of scope (still legacy / stub-only with the flag on, queued in follow-up PRs in this stack): trackers-blocked, main-network, no-trackers, fire-button, end. Their Dax*BrandDesignUpdateContextualCta classes remain as scaffolding.

Steps to test this PR

Designs

Please run all testing steps for in-context dialog changes from the contextual-end branch/PR to ease the testing burden.

To see these changes patch (Linear onboarding flag included just for continuity)

Index: app/src/main/java/com/duckduckgo/app/onboardingbranddesignupdate/OnboardingBrandDesignUpdateToggles.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/app/src/main/java/com/duckduckgo/app/onboardingbranddesignupdate/OnboardingBrandDesignUpdateToggles.kt b/app/src/main/java/com/duckduckgo/app/onboardingbranddesignupdate/OnboardingBrandDesignUpdateToggles.kt
--- a/app/src/main/java/com/duckduckgo/app/onboardingbranddesignupdate/OnboardingBrandDesignUpdateToggles.kt	(revision 6fd565c8894daba16281ae9bcf3452d038ae8d6d)
+++ b/app/src/main/java/com/duckduckgo/app/onboardingbranddesignupdate/OnboardingBrandDesignUpdateToggles.kt	(date 1777967047929)
@@ -34,13 +34,13 @@
      * Main toggle for the onboarding brand design update feature.
      * Default value: false (disabled).
      */
-    @Toggle.DefaultValue(DefaultFeatureValue.FALSE)
+    @Toggle.DefaultValue(DefaultFeatureValue.TRUE)
     fun self(): Toggle
 
     /**
      * Toggle for the brand design update variant.
      * Default value: false (disabled).
      */
-    @Toggle.DefaultValue(DefaultFeatureValue.FALSE)
+    @Toggle.DefaultValue(DefaultFeatureValue.TRUE)
     fun brandDesignUpdate(): Toggle
 }
Index: app/src/main/java/com/duckduckgo/app/onboarding/ui/OnboardingViewModel.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/app/src/main/java/com/duckduckgo/app/onboarding/ui/OnboardingViewModel.kt b/app/src/main/java/com/duckduckgo/app/onboarding/ui/OnboardingViewModel.kt
--- a/app/src/main/java/com/duckduckgo/app/onboarding/ui/OnboardingViewModel.kt	(revision 6fd565c8894daba16281ae9bcf3452d038ae8d6d)
+++ b/app/src/main/java/com/duckduckgo/app/onboarding/ui/OnboardingViewModel.kt	(date 1777657893440)
@@ -45,7 +45,7 @@
     val viewState = _viewState.asStateFlow()
 
     fun initializePages() {
-        pageLayoutManager.buildPageBlueprints()
+        pageLayoutManager.buildBrandDesignUpdatePageBlueprints()
     }
 
     fun pageCount(): Int {
@@ -69,8 +69,8 @@
         }
     }
 
-    fun initializeOnboardingSkipper() {
-        if (!appBuildConfig.canSkipOnboarding) return
+    fun initializeOnboardingSkipper() { 
+        return
 
         // delay showing skip button until privacy config downloaded
         viewModelScope.launch {

UI changes

Screenshots

---

Note

Medium Risk
Moderate risk because it changes the in-context onboarding CTA class used under the brand-design flag and wires up option rendering/click handling, which could affect onboarding flow and analytics pixels.

Overview
Implements the brand-design variant of the in-context Site Suggestions onboarding dialog by populating DaxSiteSuggestionsBrandDesignUpdateContextualCta with a real layout (activeIncludeId), banner background, title/description binding, and option button setup/click handlers.

Updates CtaViewModel.getSiteSuggestionsDialogCta to return the new brand-design CTA when the flag is enabled (passing theme), and ensures the custom “visit site” pixel path treats the new CTA the same as the legacy one. Adds a dedicated unit test to verify the correct CTA class is returned under the flag and that key pixels (shown/ok/dismiss) still fire with the expected parameters.

^{Reviewed by Cursor Bugbot for commit c0ff122. Bugbot is set up for automated code reviews on this repo. Configure here.}

[mikescamell]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Onboarding Brand Design Update: Dismiss intro bubble on submit #8526
• Onboarding Brand Design Update: Update welcome screen copy #8515
• Onboarding Brand Design Update: Add Default Browser page #8514
• Onboarding Brand Design Update: Add in-context End dialog #8484
• Onboarding Brand Design Update: Add in-context Fire Button dialog + Inferno fire animation #8482
• Onboarding Brand Design Update: Add in-context No Trackers dialog #8481
• Onboarding Brand Design Update: Add in-context Main Network dialog #8480
• Onboarding Brand Design Update: Add in-context Trackers Blocked dialog #8479
• Onboarding Brand Design Update: Add in-context Site Suggestions dialog #8483 👈 (View in Graphite)
• Onboarding Brand Design Update: Add in-context SERP dialog #8439
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit a199fa5. Configure here.}