Skip to content

Conversation

@vkraucunas
Copy link
Contributor

Asana Task/Github Issue:

Description

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@vkraucunas vkraucunas requested review from a team, mgurgel and shakyShane as code owners December 16, 2024 15:31
@github-actions
Copy link
Contributor

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions
Copy link
Contributor

[Beta] Generated file diff

Time updated: Mon, 16 Dec 2024 15:32:58 GMT

Integration
    - integration/pages/new-tab/js/index.js

File has changed

Windows
    - windows/pages/new-tab/js/index.js

File has changed

Apple
    - dist/pages/new-tab/js/index.js

File has changed

@vkraucunas vkraucunas merged commit 38f40c2 into vkraucunas/freemium-pir-banner Dec 16, 2024
11 checks passed
@vkraucunas vkraucunas deleted the shane/freemium-update branch December 16, 2024 15:40
vkraucunas added a commit that referenced this pull request Dec 16, 2024
Co-authored-by: Shane Osbourne <shane.osbourne8@gmail.com>
vkraucunas added a commit that referenced this pull request Dec 16, 2024
Co-authored-by: Shane Osbourne <shane.osbourne8@gmail.com>
vkraucunas added a commit that referenced this pull request Dec 16, 2024
* feat: Create MessageBar component

* feat: Use MessageBar in RMF

* wip

* chore: fix typing maybe?

* chore: Add to page

* chore: Undo the message bar creation

* fix: compnents view

* fix: Typing issue in NextStepsCards

* fix: naming is hard

* chore: Change PIRBanner message shape

* chore: Move convertMarkdownToHTMLForStrongTags to util file

* fix: naming

* chore: Add tests for the markdown convert util

* chore: Add Playwright tests

* docs: Add PIR Banner docs

* fix: test pause

* fix: mocktransport

* added xss test (#1330)

Co-authored-by: Shane Osbourne <shane.osbourne8@gmail.com>

* chore: Readd icon after rebase

* path update

---------

Co-authored-by: Shane Osbourne <shane.osbourne8@gmail.com>
mallexxx pushed a commit that referenced this pull request Jul 17, 2025
* feat: Create MessageBar component

* feat: Use MessageBar in RMF

* wip

* chore: fix typing maybe?

* chore: Add to page

* chore: Undo the message bar creation

* fix: compnents view

* fix: Typing issue in NextStepsCards

* fix: naming is hard

* chore: Change PIRBanner message shape

* chore: Move convertMarkdownToHTMLForStrongTags to util file

* fix: naming

* chore: Add tests for the markdown convert util

* chore: Add Playwright tests

* docs: Add PIR Banner docs

* fix: test pause

* fix: mocktransport

* added xss test (#1330)

Co-authored-by: Shane Osbourne <shane.osbourne8@gmail.com>

* chore: Readd icon after rebase

* path update

---------

Co-authored-by: Shane Osbourne <shane.osbourne8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants