Skip to content

added xss test #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vkraucunas merged 1 commit into from
Dec 16, 2024
Merged

added xss test #1330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions special-pages/pages/new-tab/app/freemium-pir-banner/freemiumPIRBanner.utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,28 @@
*/

export function convertMarkdownToHTMLForStrongTags(markdown) {
// first, remove any HTML tags
markdown = escapeXML(markdown);

// Use a regular expression to find all the words wrapped in **
const regex = /\*\*(.*?)\*\*/g;

// Replace the matched text with the HTML <strong> tags
const result = markdown.replace(regex, '<strong>$1</strong>');
return result;
}

/**
* Escapes any occurrences of &, ", <, > or / with XML entities.
*/
function escapeXML(str) {
const replacements = {
'&': '&amp;',
'"': '&quot;',
"'": '&apos;',
'<': '&lt;',
'>': '&gt;',
'/': '&#x2F;',
};
return String(str).replace(/[&"'<>/]/g, (m) => replacements[m]);
}
7 changes: 7 additions & 0 deletions special-pages/pages/new-tab/app/freemium-pir-banner/unit-tests/utils.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,11 @@ describe('convertMarkdownToHTMLForStrongTags', () => {
const actual = convertMarkdownToHTMLForStrongTags(str);
equal(actual, expected);
});

it('ignores HTML', () => {
const str = 'abc **def** <script>alert(document.cookie)</script>';
const expected = 'abc <strong>def</strong> &lt;script&gt;alert(document.cookie)&lt;&#x2F;script&gt;';
const actual = convertMarkdownToHTMLForStrongTags(str);
equal(actual, expected);
});
});
Loading