Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 8, 2025

Bumps the typescript group with 4 updates in the / directory: typedoc, typescript, @types/chrome and @types/node.

Updates typedoc from 0.28.8 to 0.28.15

Release notes

Sourced from typedoc's releases.

v0.28.15

Features

  • The gitRevision option now accepts the special value {branch}, which indicates source links should use the current git branch for links, #3041.
  • Introduced validation.invalidPath for suppressing warnings caused by referencing relative paths which do not exist when building the documentation, #3033.
  • API: Introduced Logger.validationWarning for validation which occurs during conversion rather than during TypeDoc's normal validation step, #3033.

v0.28.14

Features

  • Introduced the preservedTypeAnnotationTags option to specify tags whose type annotations should be copied to the output documentation, #3020. API: Introduced typeAnnotation on CommentTag
  • Added excludePrivateClassFields option to hide #private members while allowing private members, #3017.
  • Added support for TypeScript's @this tag for JS files which describe this parameters, #3026.

Bug Fixes

  • Fixed conversion of auto-accessor types on properties with the accessor keyword, #3019.
  • Improved handling of HTML tags within headers for anchor generation, #3023.
  • Improved support for detecting destructured parameters and renaming them to the name used in the doc comment, #3026.

v0.28.13

Features

  • The basePath option now also affects relative link resolution, TypeDoc will also check for paths relative to the provided base path. If you instead want TypeDoc to only change the rendered base path for sources, use the displayBasePath option, #3009.

Bug Fixes

  • Fixed bug introduced in 0.28.8 where TypeDoc could not render docs with some mixin classes, #3007.
  • @inheritDoc will now correctly overwrite @remarks and @returns blocks on the target comment, #3012.
  • The externalSymbolLinkMappings option now works properly on links pointing to inherited/overwritten signatures, #3014.

v0.28.12

Bug Fixes

  • Variables marked with @enum now work for symbols imported from another module, #3003.
  • Improved magic introduced with #2999 to work with imported symbols, #3003.
  • Fixed relative link resolution to file names containing percent encoded URLs, #3006.
  • Linking to the project's README file with a relative link will now behave as expected, #3006.
  • Reduced unnecessary HTML element rendering in default theme.

... (truncated)

Changelog

Sourced from typedoc's changelog.

v0.28.15 (2025-11-29)

Features

  • The gitRevision option now accepts the special value {branch}, which indicates source links should use the current git branch for links, #3041.
  • Introduced validation.invalidPath for suppressing warnings caused by referencing relative paths which do not exist when building the documentation, #3033.
  • API: Introduced Logger.validationWarning for validation which occurs during conversion rather than during TypeDoc's normal validation step, #3033.

v0.28.14 (2025-10-11)

Features

  • Introduced the preservedTypeAnnotationTags option to specify tags whose type annotations should be copied to the output documentation, #3020. API: Introduced typeAnnotation on CommentTag
  • Added excludePrivateClassFields option to hide #private members while allowing private members, #3017.
  • Added support for TypeScript's @this tag for JS files which describe this parameters, #3026.
  • API: Re-introduced relevanceBoost on DeclarationReflection for plugin use, #3036.

Bug Fixes

  • Fixed conversion of auto-accessor types on properties with the accessor keyword, #3019.
  • Improved handling of HTML tags within headers for anchor generation, #3023.
  • Improved support for detecting destructured parameters and renaming them to the name used in the doc comment, #3026.
  • Constructor type parameters will now inherit their class's type parameter descriptions if not otherwise specified, #3031.
  • Fixed compatibility with @microsoft/tsdoc-config version 0.18.0, #3035.
  • Custom theme icons will now be used in the "On This Page" sidebar, #3039.

Thanks!

v0.28.13 (2025-09-14)

Features

  • The basePath option now also affects relative link resolution, TypeDoc will also check for paths relative to the provided base path. If you instead want TypeDoc to only change the rendered base path for sources, use the displayBasePath option, #3009.

Bug Fixes

  • Fixed bug introduced in 0.28.8 where TypeDoc could not render docs with some mixin classes, #3007.
  • @inheritDoc will now correctly overwrite @remarks and @returns blocks on the target comment, #3012.
  • The externalSymbolLinkMappings option now works properly on links pointing to inherited/overwritten signatures, #3014.

... (truncated)

Commits

Updates typescript from 5.8.3 to 5.9.3

Release notes

Sourced from typescript's releases.

TypeScript 5.9.3

Note: this tag was recreated to point at the correct commit. The npm package contained the correct content.

For release notes, check out the release announcement

Downloads are available on:

TypeScript 5.9

Note: this tag was recreated to point at the correct commit. The npm package contained the correct content.

For release notes, check out the release announcement

Downloads are available on:

TypeScript 5.9 RC

Note: this tag was recreated to point at the correct commit. The npm package contained the correct content.

For release notes, check out the release announcement

Downloads are available on:

TypeScript 5.9 Beta

Note: this tag was recreated to point at the correct commit. The npm package contained the correct content.

For release notes, check out the release announcement.

Downloads are available on:

Commits
  • c63de15 Bump version to 5.9.3 and LKG
  • 8428ca4 🤖 Pick PR #62438 (Fix incorrectly ignored dts file fr...) into release-5.9 (#...
  • a131cac 🤖 Pick PR #62351 (Add missing Float16Array constructo...) into release-5.9 (#...
  • 0424333 🤖 Pick PR #62423 (Revert PR 61928) into release-5.9 (#62425)
  • bdb641a 🤖 Pick PR #62311 (Fix parenthesizer rules for manuall...) into release-5.9 (#...
  • 0d9b9b9 🤖 Pick PR #61978 (Restructure CI to prepare for requi...) into release-5.9 (#...
  • 2dce0c5 Intentionally regress one buggy declaration output to an older version (#62163)
  • 5be3346 Bump version to 5.9.2 and LKG
  • ad825f2 Bump version to 5.9.1-rc and LKG
  • 463a5bf Update LKG
  • Additional commits viewable in compare view

Updates @types/chrome from 0.1.1 to 0.1.32

Commits

Updates @types/node from 24.1.0 to 24.10.1

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Note

Upgrade TypeScript/TypeDoc and typings, adjust MediaSession shim and tests, and refine WebKit decrypt typings and minor JSDoc/imports.

  • Dependencies:
    • Upgrade typescript to 5.9.3 and typedoc to 0.28.15 (root and injected).
    • Update typings: @types/chrome to 0.1.32, @types/node to 24.10.1.
  • Web compat/shims:
    • Make MediaSession#setCameraActive/#setMicrophoneActive async and update related tests.
    • Minor JSDoc import placement in navigator-interface.
  • Messaging (WebKit):
    • Tighten decrypt argument types with explicit BufferSource casts.
  • Tests:
    • Cookie protection tests: use optional chaining and clarify @ts-expect-error on expires.
    • Unit tests adjusted to reflect async MediaSession methods and descriptor edge cases.

Written by Cursor Bugbot for commit d53083b. This will update automatically on new commits. Configure here.

@dependabot dependabot bot added dependencies Update one or more dependencies version minor Increment the minor version when merged labels Dec 8, 2025
@dependabot dependabot bot requested a review from a team as a code owner December 8, 2025 10:02
@dependabot dependabot bot added dependencies Update one or more dependencies version minor Increment the minor version when merged labels Dec 8, 2025
@netlify
Copy link

netlify bot commented Dec 8, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit d53083b
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/6936de4006a6de0007e768d1
😎 Deploy Preview https://deploy-preview-2089--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jonathanKingston
Copy link
Contributor

@cursoragent is there any resolution to the following or do we have to wait for dep updates?


npm error While resolving: typescript-eslint@8.36.0
npm error Found: typescript@5.9.3
npm error node_modules/typescript
npm error   dev typescript@"^5.9.3" from the root project
npm error   peer typescript@">=4.8.4 <6.0.0" from @typescript-eslint/eslint-plugin@8.46.0
npm error   node_modules/@typescript-eslint/eslint-plugin
npm error     dev @typescript-eslint/eslint-plugin@"^8.46.0" from the root project
npm error   17 more (@typescript-eslint/project-service, ...)
npm error
npm error Could not resolve dependency:
npm error peer typescript@">=4.8.4 <5.9.0" from typescript-eslint@8.36.0
npm error node_modules/typescript-eslint
npm error   dev typescript-eslint@"^8.36.0" from the root project
npm error
npm error Conflicting peer dependency: typescript@5.8.3
npm error node_modules/typescript
npm error   peer typescript@">=4.8.4 <5.9.0" from typescript-eslint@8.36.0
npm error   node_modules/typescript-eslint
npm error     dev typescript-eslint@"^8.36.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /home/runner/.npm/_logs/2025-12-08T10_02_47_913Z-eresolve-report.txt
npm error A complete log of this run can be found in: /home/runner/.npm/_logs/2025-12-08T10_02_47_913Z-debug-0.lo

@cursor
Copy link

cursor bot commented Dec 8, 2025

Resolution applied: Bumped typescript-eslint from ^8.36.0 to ^8.48.1, which supports TypeScript 5.9.

Additionally, I fixed several TypeScript 5.9 compatibility issues that emerged with stricter type checking:

  • click-to-load.js: Replaced Promise.all with a for-loop since createPlaceholderElementAndReplace() is synchronous
  • cookie.spec.js: Removed stale @ts-expect-error comments (cookieStore types now exist), added optional chaining for nullable results
  • web-compat.js & wrapper-utils.js: Made setCameraActive() and setMicrophoneActive() async to match updated MediaSession interface
  • webkit.js: Added BufferSource casts via unknown for stricter Uint8Array/ArrayBuffer compatibility
  • navigator-interface.js: Moved @import JSDoc to file level (TS 5.9 requires imports at top of file)
  • content-feature.js: Added @ts-expect-error for test edge cases with null values

Lint and unit tests now pass. Build succeeds.


Open in Cursor Open in Web

Learn more about Cursor Agents

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/main/typescript-b6c176eb0e branch from b9a87df to d36cf09 Compare December 8, 2025 10:21
@cursor
Copy link

cursor bot commented Dec 8, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/main/typescript-b6c176eb0e branch 10 times, most recently from 35fb859 to acdfc93 Compare December 8, 2025 13:20
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@jonathanKingston
Copy link
Contributor

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/main/typescript-b6c176eb0e branch from acdfc93 to c5bf97f Compare December 8, 2025 13:43
@jonathanKingston
Copy link
Contributor

@cursoragent can you review the test fails and fix them:



Error: injected/integration-test/cookie.spec.js(13,13): error TS2578: Unused '@ts-expect-error' directive.
Error: injected/integration-test/cookie.spec.js(17,16): error TS18047: 'result' is possibly 'null'.
Error: injected/integration-test/cookie.spec.js(18,16): error TS18047: 'result' is possibly 'null'.
Error: injected/integration-test/cookie.spec.js(19,16): error TS18047: 'result' is possibly 'null'.
Error: injected/integration-test/cookie.spec.js(19,23): error TS2339: Property 'expires' does not exist on type 'CookieListItem'.
Error: injected/integration-test/cookie.spec.js(35,13): error TS2578: Unused '@ts-expect-error' directive.
Error: injected/integration-test/cookie.spec.js(39,16): error TS18047: 'result' is possibly 'null'.
Error: injected/integration-test/cookie.spec.js(40,16): error TS18047: 'result' is possibly 'null'.
Error: injected/integration-test/cookie.spec.js(41,16): error TS18047: 'result' is possibly 'null'.
Error: injected/integration-test/cookie.spec.js(41,23): error TS2339: Property 'expires' does not exist on type 'CookieListItem'.
Error: injected/integration-test/cookie.spec.js(57,13): error TS2578: Unused '@ts-expect-error' directive.
Error: injected/integration-test/cookie.spec.js(61,16): error TS18047: 'result' is possibly 'null'.
Error: injected/integration-test/cookie.spec.js(62,16): error TS18047: 'result' is possibly 'null'.
Error: injected/integration-test/cookie.spec.js(63,16): error TS18047: 'result' is possibly 'null'.
Error: injected/integration-test/cookie.spec.js(63,23): error TS2339: Property 'expires' does not exist on type 'CookieListItem'.
Error: injected/src/features/navigator-interface.js(38,33): error TS2304: Cannot find name 'MessagingInterface'.
Error: injected/src/features/web-compat.js(733,48): error TS2345: Argument of type 'typeof MyMediaSession' is not assignable to parameter of type '{ new (): MediaSession; prototype: MediaSession; }'.
  The types returned by 'prototype.setCameraActive(...)' are incompatible between these types.
    Type 'void' is not assignable to type 'Promise<void>'.
Error: injected/src/features/web-compat.js(738,68): error TS2345: Argument of type 'MyMediaSession' is not assignable to parameter of type 'MediaSession'.
  The types returned by 'setCameraActive(...)' are incompatible between these types.
    Type 'void' is not assignable to type 'Promise<void>'.
Error: injected/unit-test/content-feature.js(513,37): error TS2345: Argument of type '{ get: null; set: undefined; enumerable: true; configurable: true; }' is not assignable to parameter of type 'Expected<PropertyDescriptor | undefined>'.
  Types of property 'get' are incompatible.
    Type 'null' is not assignable to type 'ExpectedRecursive<(() => any) | undefined>'.
Error: injected/unit-test/content-feature.js(514,17): error TS2578: Unused '@ts-expect-error' directive.
Error: injected/unit-test/content-feature.js(536,37): error TS2345: Argument of type '{ get: undefined; set: null; enumerable: true; configurable: true; }' is not assignable to parameter of type 'Expected<PropertyDescriptor | undefined>'.
  Types of property 'set' are incompatible.
    Type 'null' is not assignable to type 'ExpectedRecursive<((v: any) => void) | undefined>'.
Error: injected/unit-test/content-feature.js(538,17): error TS2578: Unused '@ts-expect-error' directive.
Error: injected/unit-test/wrapper-utils.js(14,9): error TS2322: Type 'typeof MyMediaSession' is not assignable to type '{ new (): MediaSession; prototype: MediaSession; }'.
  The types returned by 'prototype.setCameraActive(...)' are incompatible between these types.
    Type 'void' is not assignable to type 'Promise<void>'.
Error: messaging/lib/webkit.js(132,58): error TS2345: Argument of type 'Uint8Array<ArrayBufferLike>' is not assignable to parameter of type 'BufferSource'.
  Type 'Uint8Array<ArrayBufferLike>' is not assignable to type 'ArrayBufferView<ArrayBuffer>'.
    Types of property 'buffer' are incompatible.
      Type 'ArrayBufferLike' is not assignable to type 'ArrayBuffer'.
        Type 'SharedArrayBuffer' is not assignable to type 'ArrayBuffer'.
          Types of property '[Symbol.toStringTag]' are incompatible.
            Type '"SharedArrayBuffer"' is not assignable to type '"ArrayBuffer"'.
Error: Process completed with exit code 2.

@cursor
Copy link

cursor bot commented Dec 8, 2025

The code is already fixed. All fixes from my previous work are applied:

Lint passes
TypeScript check passes
Unit tests pass

The CI errors you shared are from commit c5bf97fd3a7cdc8d0b12cc1c7b86e64db585356f, but based on the attached files showing your changes, the fixes have already been applied:

File Fix Applied
cookie.spec.js Optional chaining (result?.name), @ts-expect-error for expires
navigator-interface.js @import moved to file level
web-compat.js async setCameraActive(), async setMicrophoneActive()
wrapper-utils.js Same async methods
content-feature.js @ts-expect-error directives repositioned
webkit.js BufferSource casts via unknown
click-to-load.js for-loop instead of Promise.all
package.json typescript-eslint bumped to ^8.48.1

The CI should pass on the next run with the current code. If it's still failing, try re-triggering the CI workflow.


Open in Cursor Open in Web

Learn more about Cursor Agents

@cursor cursor bot force-pushed the dependabot/npm_and_yarn/main/typescript-b6c176eb0e branch from c5bf97f to 031dd4a Compare December 8, 2025 14:01
@cursor cursor bot requested review from franfaccin, kzar and ladamski as code owners December 8, 2025 14:01
@cursor cursor bot requested a review from shakyShane as a code owner December 8, 2025 14:01
cursoragent and others added 3 commits December 8, 2025 14:12
Co-authored-by: jkingston <jkingston@duckduckgo.com>
Co-authored-by: jkingston <jkingston@duckduckgo.com>
@cursor cursor bot force-pushed the dependabot/npm_and_yarn/main/typescript-b6c176eb0e branch from 031dd4a to d53083b Compare December 8, 2025 14:18
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

[Beta] Generated file diff

Time updated: Mon, 08 Dec 2025 14:19:41 GMT

Android
    - android/adsjsContentScope.js
  • android/autofillImport.js
  • android/brokerProtection.js
  • android/contentScope.js
  • android/pages/duckplayer/dist/index.js

File has changed

Apple
    - apple/contentScope.js
  • apple/contentScopeIsolated.js
  • apple/pages/duckplayer/dist/index.js
  • apple/pages/duckplayer/index.html
  • apple/pages/history/dist/index.js
  • apple/pages/new-tab/dist/index.js
  • apple/pages/onboarding/dist/index.js
  • apple/pages/release-notes/dist/index.js
  • apple/pages/special-error/dist/index.js
  • apple/pages/special-error/index.html

File has changed

Chrome-mv3
    - chrome-mv3/inject.js

File has changed

Firefox
    - firefox/inject.js

File has changed

Integration
    - integration/contentScope.js
  • integration/pages/duckplayer/dist/index.js
  • integration/pages/example/dist/index.js
  • integration/pages/history/dist/index.js
  • integration/pages/new-tab/dist/index.js
  • integration/pages/onboarding/dist/index.js
  • integration/pages/release-notes/dist/index.js
  • integration/pages/special-error/dist/index.js

File has changed

Windows
    - windows/contentScope.js
  • windows/pages/duckplayer/dist/index.js
  • windows/pages/history/dist/index.js
  • windows/pages/new-tab/dist/index.js
  • windows/pages/onboarding/dist/index.js
  • windows/pages/release-notes/dist/index.js
  • windows/pages/special-error/dist/index.js
  • windows/pages/special-error/index.html

File has changed

@jonathanKingston jonathanKingston added this pull request to the merge queue Dec 8, 2025
Merged via the queue into main with commit 49e47d3 Dec 8, 2025
16 of 17 checks passed
@jonathanKingston jonathanKingston deleted the dependabot/npm_and_yarn/main/typescript-b6c176eb0e branch December 8, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Update one or more dependencies version minor Increment the minor version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants