Skip to content

v2.4.3 — Plugin Check follow-up

Choose a tag to compare

View all tags
@dukenukemall dukenukemall released this 18 May 09:52
· 5 commits to main since this release
v2.4.3
28128a0

v2.4.3 — Plugin Check follow-up

Tiny correctness fix on top of v2.4.2.

What

The three phpcs:ignore WordPress.DB.SlowDBQuery.* annotations added in v2.4.2 didn't actually suppress their warnings. Reason: phpcs:ignore applies only to the immediately next line, but the slow-query sniff fires on the 'meta_key' / 'meta_value' / 'meta_query' array-key string tokens which live 2-3 lines inside the wc_get_orders() / get_posts() array literal.

Fix

Switched each of the three sites to range-based phpcs:disable / phpcs:enable pairs that wrap just the offending array literal:

  • Fungies_Order_Sync::find_order_by_meta()
  • Fungies_Return_Resolver::by_meta()
  • Fungies_Product_Sync::push_to_fungies() (the meta_query array)

The rationale comments above each suppression are preserved so reviewers still see why the suppression is justified (low-cardinality indexed Fungies meta keys, single-row lookups).

No runtime changes

This is a lint-only fix. Drop-in replacement for v2.4.2.

Assets 3
Loading