feat(t103): cross-device pin and history sync with new tab omnibox#16
Merged
Conversation
Dokploy Preview Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins and browsing history now sync across devices via the web server, and the New Tab modal becomes an omnibox. See ADR-0017.
syncOrLocal, falling back to the local store on any network failure. First enable is server-wins (Electron re-loads the server's pins).core/history-store.jsrecords it by diffing the existing/jsontab poll (page targets only) into frecency-ranked visits, persisted server-side (web-history.json) and served at/api/history.new-tab-dialog.tsxnow suggests history (matched on URL and title, diacritic-safe) plus a "Switch to tab" action for tabs already open (CDP + local), keeping the pinned quick-launch row for the empty state.Testing
core/history-store.test.ts+src/lib/tab-suggest.test.ts(25 tests).pnpm typecheck,pnpm test(1049),pnpm test:e2e(49) green; biome clean on changed files.Task: docs/tasks/done/103-sync-pins-and-history-across-devices-with-new-tab.md
ADR: docs/adr/0017-shared-sync-backend-for-pins-and-history.md