DDS-014N: Add Dutch Drone Squad about page - #33
Merged
Conversation
klaasnicolaas
marked this pull request as draft
July 27, 2026 00:41
klaasnicolaas
marked this pull request as ready for review
July 27, 2026 00:41
There was a problem hiding this comment.
Pull request overview
Deze PR vervangt de bestaande generieke /about-pagina (config-gedreven public/shell) door een dedicated, code-owned Inertia React pagina (public/about) die het DDS-verhaal, de tijdlijn en het team presenteert, inclusief bijgewerkte navigatie-/footer-groepering en SEO.
Changes:
- Nieuwe Inertia React pagina
resources/js/pages/public/about.tsxmet inhoud (hero, oorsprong, tijdlijn, piloten/bezoekers, team) en mobiele teamlijst met horizontale scroll. /aboutroute omgezet naarpublic/about+ SEO aangepast naar titel/omschrijving passend bij de nieuwe pagina.- Feature- en browser-tests uitgebreid/aangepast voor nieuwe routecontracten, navigatietekst en inhoudelijke assertions.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/Feature/PublicStaticPagesTest.php | Voegt dedicated test toe voor /about als code-owned pagina en verwijdert /about uit de generieke “page contract” dataset. |
| tests/Browser/PublicSiteTest.php | Past navigatie-assertions aan (Informatie → Dutch Drone Squad) en voegt uitgebreide end-to-end test toe voor de nieuwe about page. |
| routes/web.php | Route /about switched van public/shell met config-content naar dedicated public/about met SEO metadata. |
| resources/js/pages/public/about.tsx | Nieuwe about pagina met DDS-verhaal, timeline en teamsectie (incl. placeholders en mobile scroll UX). |
| resources/js/layouts/public-layout.tsx | Wijzigt navigatie-/footer-labeling naar “Dutch Drone Squad” en past header scrolled styling aan. |
| config/seo.php | Update SEO voor about (title/description) naar nieuwe inhoud. |
| config/public_pages.php | Verwijdert legacy about config content. |
Comments suppressed due to low confidence (1)
resources/js/pages/public/about.tsx:103
gettingStartedIndex({ ... }).urlhas the same issue as above: it calls the route helper and then reads.url, which is inconsistent with how these helpers are used elsewhere (e.g.gettingStartedIndex.url()), and can produce the wrong value type forPublicHero.
Use gettingStartedIndex.url({ query: ... }) to get a string URL.
label: 'Lees hoe je begint',
href: gettingStartedIndex({
query: { source: 'about-hero' },
}).url,
},
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wat is gewijzigd
/about-pagina door een eigen Over DDS-pagina.Informatieals navigatiegroep en gebruiktDutch Drone Squadals footerkop, metOver DDS,ProjectenenPartnerseronder.Waarom
DDS-014N geeft bezoekers één duidelijke plek om te lezen waar Dutch Drone Squad vandaan komt, hoe de events zijn opgezet en wie ze organiseert. De tekst is bewust feitelijk en compact gehouden.
Impact
De publieke route
/aboutgebruikt voortaan een code-owned Inertia-pagina. De bestaande statische About-configuratie is verwijderd. Andere publieke pagina’s en routes blijven ongewijzigd.Validatie
php artisan test --compact tests/Feature/PublicStaticPagesTest.php— 5 tests, 72 assertionsphp artisan test --compact tests/Browser/PublicSiteTest.php --filter='about page tells the DDS story'— 1 test, 83 assertionsnpm run types:checknpm run buildgit diff --checkVervolg
De echte portretfoto’s worden apart opgepakt in #32.