Micro optimize setCustomAttribute call.#39
Merged
Conversation
dvicklund
approved these changes
Dec 6, 2023
Owner
dvicklund
left a comment
There was a problem hiding this comment.
Seems like a reasonable change - the hasCustomAttribute function is nonsense anyway - no need to get a model to see if it exists, then subsequently getCustomAttribute to return the actual model to the caller. Much better to minimize redundant calls. Merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Micro optimization for
CustomAttributeTrait.The
setCustomAttributemethod had two fetches for the database for getting the custom attribute when the$attrwasn't a model and the attribute existed.Now, the method just tries to resolve the attribute object by called
resolveCustomAttributeObjectin 3 ways.CustomAttributegetCustomAttribute(which just actually checks if there is aCustomAttributeValuefor the item tied to theCustomAttributein question)CustomAttributefrom the actual table