Fix broken Weekly CI and modernize runner configuration - #383
Merged
Conversation
The windows-2025 runner now includes Visual Studio 2026. CMake auto-detects it but msbuild fails to find the FlatCC.sln. Using cmake --build is generator-agnostic and avoids depending on the solution filename. Also remove the microsoft/setup-msbuild action since cmake finds MSBuild through the VS installation directly. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Add Debian 13 (Trixie, current stable) and remove Debian 11 (Bullseye) which reached end of life in 2024. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
This was referenced Jul 28, 2026
Move jobs with modern compilers to ubuntu-26.04. Keep ubuntu-24.04 for old clang/gcc versions and CMake 3.16 where newer glibc or missing packages could cause issues. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
- actions/checkout v6.0.1 to v7.0.1 - aminya/setup-cpp v1.7.1 to v1.8.1 - jwlawson/actions-setup-cmake v2.0.2 to v2.2.0 - uraimo/run-on-arch-action v3.0.1 to v3.1.0 Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Old compilers only works on older ubuntu baselines providing `libtinfo.so.5`. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Collaborator
Author
|
I pushed again, had to revert back to use ubuntu-24.04 in the gcc job, avoiding ubuntu-22.04 |
Collaborator
Author
|
I need to fix a flakyness in clang-5 to 15 first, the first attempt did not work. Hold on |
Contributor
|
Impressive regression on LTS ... |
The libtinfo5 package is part of ncurses and the version 6.4-2ubuntu0.1 is a specific security patch for Ubuntu 24.04. It could get a new version if there's another security fix, but that's rare for a legacy compatibility package. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Collaborator
Author
|
Well, now it seems stable, been rerunning 5+ times. So these are the proposed updates. Yeah, LTS sounds good. Then it doesn't help that Github constantly changes what their runners consists of. |
Contributor
|
Awesome, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmake --buildto handle VS 2026 onwindows-2025runnerRemove action
microsoft/setup-msbuildsince its not needed when we let CMake build.Windows Visual Studio 11-armmacos-14runner withmacos-26Bullseye(11), addTrixie(13)This replaces the dependabot PRs.
The
aminya/setup-cppaction still gives annotations/warnings when retrying to add apt keys, but it succeeds to install the compilers. (Weekly run: https://github.com/Nordix/flatcc/actions/runs/30353387666)