Exact-solve for ground state in MockDWaveSampler on small problems#476
Conversation
042345f to
7b06046
Compare
efa503a to
2bbc9fb
Compare
Scipy 1.9.3 on python 3.10 on windows has issues with numpy compatibility; pin to an older version (that works across the whole range of supported pythons) as a temporary workaround. Note: scipy is used (only) by dwave-drivers, i.e. only by `VirtualGraphComposite` in dwave-system.
2bbc9fb to
e1d0f25
Compare
jackraymond
left a comment
There was a problem hiding this comment.
Perhaps docstring could be improved, since it is not clear how sampleset are impacted. Perhaps the docstring for the sample function would be the appropriate place.
Functionally looks good, I wonder if it would be a good idea to set an explicit upper bound on exact_solver_cutoff to prevent users being surprised by slow regimes or ExactSolver errors.
|
Thanks @jackraymond, I updated the docstring as suggested, except that I kept a reference to |
e0546a5 to
d870d58
Compare
By default, problems of size 16 and smaller will be sampled with greedy sampler and then an
ExactSolver-determined ground state will be injected.Implements a suggestion from #474 (comment).
Close #474.