Skip to content

v1.0.14 Python client: Rewards endpoints [BAC-1689]#65

Merged
jiajames merged 5 commits intomasterfrom
james-branch
Aug 16, 2021
Merged

v1.0.14 Python client: Rewards endpoints [BAC-1689]#65
jiajames merged 5 commits intomasterfrom
james-branch

Conversation

@jiajames
Copy link
Copy Markdown

Plus some other fixes

@jiajames jiajames requested a review from samweinberg23 August 16, 2021 17:27
Comment thread dydx3/modules/public.py Outdated
'''
Get public retroactive mining rewards

:param ethereumAddress: optional
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this optional? You don't have =None specified in args

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops thats required, sorry

@jiajames jiajames changed the title Python client: Rewards endpoints v1.0.14 Python client: Rewards endpoints Aug 16, 2021
@jiajames jiajames merged commit 6589086 into master Aug 16, 2021
@jiajames jiajames deleted the james-branch branch August 16, 2021 18:17
@jiajames jiajames changed the title v1.0.14 Python client: Rewards endpoints v1.0.14 Python client: Rewards endpoints [BAC-1689] Aug 16, 2021
@linear
Copy link
Copy Markdown

linear Bot commented Aug 16, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants