Add locale handling to Money.getCurrentCurrency test#48
Merged
marioserrano09 merged 1 commit intomainfrom Feb 12, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the finances API unit test suite to make Money.getCurrentCurrency() deterministic by controlling the JVM default Locale during the test.
Changes:
- Added
Localeimport to theMoneyTesttest class. - Updated
testGetCurrentCurrencyto temporarily set the default locale toLocale.US, assert"USD", and restore the original locale in afinallyblock.
Comment on lines
+241
to
+246
| Locale originalLocale = java.util.Locale.getDefault(); | ||
|
|
||
| try { | ||
| // Set a locale with a valid country code for testing | ||
| java.util.Locale.setDefault(java.util.Locale.US); | ||
|
|
There was a problem hiding this comment.
Locale is already imported, but the test still uses fully-qualified java.util.Locale calls. Use Locale.getDefault() / Locale.setDefault(Locale.US) consistently here to reduce noise and keep the style aligned with the rest of the codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.