Skip to content

Add locale handling to Money.getCurrentCurrency test #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marioserrano09 merged 1 commit into from
Feb 12, 2026
Merged

Add locale handling to Money.getCurrentCurrency test #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions ...ions/finances/sources/api/src/test/java/tools/dynamia/modules/finances/api/MoneyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import org.junit.jupiter.api.Test;

import java.math.BigDecimal;
import java.util.Locale;

import static org.junit.jupiter.api.Assertions.*;

Expand Down Expand Up @@ -236,10 +237,22 @@ void testGetCurrencyForLocale() {
@Test
@DisplayName("Should get current currency")
void testGetCurrentCurrency() {
String currency = Money.getCurrentCurrency();

assertNotNull(currency);
assertFalse(currency.isEmpty());
// Save the current default locale
Locale originalLocale = java.util.Locale.getDefault();

try {
// Set a locale with a valid country code for testing
java.util.Locale.setDefault(java.util.Locale.US);

Comment on lines +241 to +246
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locale is already imported, but the test still uses fully-qualified java.util.Locale calls. Use Locale.getDefault() / Locale.setDefault(Locale.US) consistently here to reduce noise and keep the style aligned with the rest of the codebase.

Copilot uses AI. Check for mistakes.
String currency = Money.getCurrentCurrency();

assertNotNull(currency);
assertFalse(currency.isEmpty());
assertEquals("USD", currency);
} finally {
// Restore the original locale
java.util.Locale.setDefault(originalLocale);
}
}

@Test
Expand Down
Loading