Skip to content

Correct framework-row mode semantics + staging wording from the post-merge review of #39#41

Merged
Justinvolved merged 1 commit into
v2from
fold/pr39-review-fixes
Jul 3, 2026
Merged

Correct framework-row mode semantics + staging wording from the post-merge review of #39#41
Justinvolved merged 1 commit into
v2from
fold/pr39-review-fixes

Conversation

@Justinvolved

Copy link
Copy Markdown
Collaborator

Post-merge review of #39 surfaced one factual error and two wording issues; all three fixed (3.8.6).

  • Framework preservation cited the wrong serializer mode. SKILL.md Step 0 and deserialize-flow.md §3 reassured that a PIM-set-up host's SHOP1/DE/EUR/LANG1 rows are preserved because 'seed mode is destination-wins' — but framework _sql/ ships in the deploy tree, and deploy is source-wins: the baseline's framework rows UPDATE matching curated rows. Both spots now carry the correct warning (review/trim deploy/_sql before deserializing into a curated host).
  • baselines\ staging wording de-contradicted — the folder is the download/staging copy the snippet copies FROM; SerializeRoot/ stays the only path the endpoint reads.
  • Files/Images/Icons/ added to the design-package copy list (verified present in the Swift clone: ~80 SVGs incl. Flags/ and LoginProviders/ — the set integrity-sweep Check 6 verifies).

Validator: 0 errors / 0 warnings; manifest up to date.

…lines staging wording; add icons to the copy list
@Justinvolved Justinvolved merged commit 09a431d into v2 Jul 3, 2026
1 check passed
@Justinvolved Justinvolved deleted the fold/pr39-review-fixes branch July 3, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant