docs(authoring): adopt scripts/ as the script packaging convention - #89
Closed
Justinvolved wants to merge 1 commit into
Closed
docs(authoring): adopt scripts/ as the script packaging convention#89Justinvolved wants to merge 1 commit into
Justinvolved wants to merge 1 commit into
Conversation
Defines how runnable scripts ship inside skills before the first wave of shared scripts lands: the file contract, PowerShell 7 as the single target with #Requires -Version 7.0, connection discovery and secrets rules, bundle closure for script imports, the fold-back gates for lifting a script out of a demo build, and the smoke-test rule for write scripts. Docs only; the validator checks and the migration of the four existing dw-setup-install scripts follow in the next PR.
Justinvolved
force-pushed
the
docs/scripts-packaging-convention
branch
from
August 28, 2026 14:13
2f475ca to
722a624
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Docs-only PR that fixes the rules before any script ships. Version 4.20.0 -> 4.21.0.
.claude/skills/dw-skill-authoring/SKILL.md, new section Shipping scripts: the script contract (scripts/layout per the Agent Skills spec, comment-based help with a READ-ONLY / WRITES opener,SupportsShouldProcesswith-WhatIfdefault beyond one row, connection discovery order with no default host/port/path/token,$env:-only secrets, one shared module indw-data-access,dw-setup-installself-contained,compatibility:frontmatter, linked## Scriptstable, forward-slashpwsh -NoProfile -Fileinvocations). Script imports count toward bundle closure.skills/dw-demo-foldback/references/fold-back-workflow.md, new Step 1c: lifting a script from a demo build. Recurrence bar, script-specific sanitization classes, one-lesson-one-home for the superseded prose, retiring the demo copy, and the smoke-test rule (write scripts local-first; a hosted install only afterwards and underdw-demo-hostedshared-install discipline).skills/dw-demo-base/references/setup-checks.md: install-grade fix for a missingpwsh.CLAUDE.md,README.md,CHANGELOG.md,marketplace.jsonversion.Two things to review deliberately
#Requires -Version 7.0; PowerShell 7 becomes a machine prerequisite installed by the setup preflight next togit,ghandnode, and scripts never branch on the version. The demo chain already mandates pwsh 7+ (setup-checks.md"Run everything from pwsh 7+"); the four existingdw-setup-installscripts are the only 5.1-compatible code and carry acurl.exe -kfallback plus an unguardedConvertFrom-Json -AsHashtablethat silently empties.mcp.jsonunder 5.1. The next PR removes that dual target. Object here if 5.1 support matters for a case not covered by "the preflight installs 7".Stacking
Based on
feat/reland-authoring-hosted-foldback(#87) becausedw-skill-authoringanddw-demo-foldbackdo not exist onmainyet. Retarget tomainafter #87 merges.Checks
python scripts/validate-skills.py: 0 errors (7 pre-existing length warnings, untouched).node scripts/build-manifest.mjs --check: up to date.