fix: add claudecode to valid targets in parser validation#2
Merged
cm-dyoshikawa merged 1 commit intodyoshikawa:mainfrom Jun 25, 2025
Merged
fix: add claudecode to valid targets in parser validation#2cm-dyoshikawa merged 1 commit intodyoshikawa:mainfrom
cm-dyoshikawa merged 1 commit intodyoshikawa:mainfrom
Conversation
Previously, the claudecode parser would generate frontmatter with targets: ["claudecode"], but the validation logic only allowed ["copilot", "cursor", "cline", "claude", "roo", "*"], causing validation errors when importing from Claude Code. This commit: - Adds "claudecode" to the validTargets array in parser.ts - Adds comprehensive tests for claudecode target validation - Ensures both "claude" and "claudecode" are valid targets Fixes the issue where `rulesync validate` would fail with: "Invalid target 'claudecode' in .rulesync/claudecode__claude-main.md"
Collaborator
|
Good catch! I will convert Thank you so much. |
Collaborator
|
I will merged it after reviewing soon. |
4 tasks
2 tasks
This was referenced Mar 8, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix validation error when importing from
CLAUDE.mdby addingclaudecodeto valid targets.Problem
importcommand to import fromCLAUDE.md, thetargetsfield is set to["claudecode"]src/core/parser.tsvalidation only allows["copilot", "cursor", "cline", "claude", "roo", "*"]Invalid target "claudecode"when runningrulesync validateSolution
claudecodeto thevalidTargetsarray insrc/core/parser.tsclaudeis already being used as a target in existing configurations, we preserve bothclaudeandclaudecodefor backward compatibilityChanges
validTargetsarray to includeclaudecodeclaudecodetarget validationclaudecodeTesting
The fix resolves the validation error while maintaining backward compatibility with existing
claudetarget configurations.Thank you for creating such an amazing tool! 🚀
Please review when you have a chance.