fix(vibe): drop the obsolete shadowed-global config warning - #2614
Merged
Conversation
Vibe v2.24.0's default_orchestrator installs the user and project TOML layers together with per-key merge strategies, so a project config.toml no longer replaces the global one and the warning was factually wrong. Remove the warning helper and its two call sites, and rewrite the docs to describe the layering, the per-key merge strategies and the AdminConfigLayer.
This was referenced Aug 8, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Closes #2594
Rulesync warned on every
--globalVibe run in a project that has its own.vibe/config.toml:That stopped being true in Vibe v2.24.0. I read
vibe/core/config/default_orchestrator.pyat HEAD to confirm: the layer stack now installs bothUserConfigLayerandProjectConfigLayer(previously exactly one was selected), and its own docstring says "a trusted project config inherits unspecified values from the user config". Only the persistence target is still resolved to a single layer. So a global write is not ignored — it is inherited by the project layer for every key the project file does not set.Changes
src/features/shared/vibe-config-scope.ts(it held onlywarnIfGlobalVibeConfigIsShadowed) and both call sites, invibe-mcp.tsandvibe-permissions.ts.VibeMcp.fromRulesyncMcpno longer destructureslogger, which it used only for this warning.--globalwrite alongside a projectconfig.tomlmust now produce no shadowing warning.vibe_schema.py—mcp_serversandconnectorsunion-merge by name,toolsdeep-merges,disabled_toolsconcatenates,enabled_toolsis replaced wholesale — and the runtimeAdminConfigLayerthat sits above everything. It stays deliberately careful about trust:ProjectConfigLayerstill carriesis_trusted, so the text says "a trusted project config overlays the user config" rather than claiming unconditional read behavior.mcp_serversunion-merged by name across layers, removing a server from the project file is not enough if a same-name entry remains in~/.vibe/config.toml.src/generated/docs-content.tsregenerated.Verification
pnpm cicheck— all green.npx vitest run --config vitest.e2e.config.ts src/e2e/e2e-permissions.spec.ts src/e2e/e2e-mcp.spec.ts— 198 passed.🤖 Generated with Claude Code