fix(scripts): drop the oxfmt pass on gitignored schema files - #2630
Merged
Conversation
Since oxfmt 0.62.0, gitignored paths are skipped even when passed explicitly, so the formatter pass in generate-json-schema.ts failed with "Expected at least one target file" and broke the Publish Assets workflow. The schema files are already written with deterministic JSON.stringify output and have no drift check, so the pass is dropped. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Publish Assetsworkflow for the v16.9.0 release failed at thepnpm generate:schemastep:Since oxfmt 0.62.0 (bumped in #2606), gitignored paths are skipped even when passed explicitly, and
--ignore-pathdoes not override this. The three generated schema files are gitignored, so the formatter pass now fails.Solution
Drop the
runOxfmtcall fromgenerate-json-schema.ts. The schema files are already written with deterministicJSON.stringify(..., null, 2)output and have no drift check (they are gitignored release assets), so the formatter pass was cosmetic only. Also document the tracked-files-only constraint inrun-oxfmt.ts, whose remaining callers (docs content, supported-tools tables) all format tracked files.Unblocks the v16.9.1 release (v16.9.0 assets were never built; npm still has 16.8.0).
🤖 Generated with Claude Code