[Suggestion] Use custom docker images #1531
Description
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when ...
Using docker has certain limitations in some places, you know some places where the wall fell docker.
So I got the emba image by some means. In https://github.com/e-m-b-a/emba/wiki/Installation, it say 'You can choose to install your own docker image, instead of the default emba docker, by using the c flag followed by the name' and use command 'sudo ./installer.sh -d -c {name-of-the-container}', I try this method and failed，-d and -c argument cannot exist simultaneously(my local image has been imported).
I use command 'sudo ./installer.sh -c {name-of-the-container}’ ,it also warned that some missing items need to be installed, but -d argument still need to be used.
So I use command sudo ./installer.sh -d and image failed(it's what I expected):
I suggest modifying the I05_emba_docker_image_dl file to avoid installation failure due to internal network problems, the local image file is read if the network fails
Describe the solution you'd like
A clear and concise description of what you want to happen.
After I modified the I05_emba_docker_image_dl.sh, again with parameters can successfully run the installation
#!/bin/bash
# EMBA - EMBEDDED LINUX ANALYZER
#
# Copyright 2020-2023 Siemens AG
# Copyright 2020-2025 Siemens Energy AG
#
# EMBA comes with ABSOLUTELY NO WARRANTY. This is free software, and you are
# welcome to redistribute it under the terms of the GNU General Public License.
# See LICENSE file for usage of this software.
#
# EMBA is licensed under GPLv3
#
# Author(s): Michael Messner, Pascal Eckmann
# Contributor(s): Stefan Haboeck, Nikolas Papaioannou
# Description: Download EMBA docker image (only for -d default and full installation)
I05_emba_docker_image_dl() {
module_title "${FUNCNAME[0]}"
if [[ "${LIST_DEP}" -eq 1 ]] || [[ "${IN_DOCKER}" -eq 0 ]] || [[ "${DOCKER_SETUP}" -eq 1 ]] || [[ "${FULL}" -eq 1 ]]; then
# print_tool_info "docker.io" 1
echo -e "\\n""${ORANGE}""${BOLD}""embeddedanalyzer/emba docker image""${NC}"
echo -e "Description: EMBA docker images used for firmware analysis."
if command -v docker > /dev/null; then
# Added error handling to prevent installation failures due to network problems
if ! f="$(docker manifest inspect "${CONTAINER}" 2>/dev/null | grep "size" | sed -e 's/[^0-9 ]//g')"; then
echo -e "${ORANGE}The container image size cannot be obtained. The installation process will continue...${NC}"
echo "Estimated download-Size: ~5500 MB"
f="0"
else
echo "Download-Size : ""$(("$(( "${f//$'\n'/+}" ))"/1048576))"" MB"
fi
fi
if [[ "${LIST_DEP}" -eq 1 ]] || [[ "${IN_DOCKER}" -eq 1 ]] ; then
ANSWER=("n")
else
echo -e "\\n""${MAGENTA}""${BOLD}""docker.io and the EMBA docker image (if not already on the system) will be downloaded and installed!""${NC}"
ANSWER=("y")
fi
case ${ANSWER:0:1} in
y|Y )
apt-get install "${INSTALL_APP_LIST[@]}" -y --no-install-recommends
if ! pgrep dockerd; then
echo -e "\\n""${RED}""${BOLD}""Docker daemon not running! Please check it manually and try again""${NC}"
exit 1
fi
if command -v docker > /dev/null ; then
export DOCKER_CLI_EXPERIMENTAL=enabled
echo -e "${ORANGE}""Checking for EMBA docker image...""${NC}"
echo -e "${ORANGE}""CONTAINER VARIABLE SET TO ""${CONTAINER}""${NC}"
# First, check whether the local mirror exists
if docker images --format "{{.Repository}}:{{.Tag}}" | grep -q "${CONTAINER}"; then
echo -e "${GREEN}""Found local image ${CONTAINER}, skipping download.""${NC}"
else
echo -e "${ORANGE}""Local image not found, attempting to download.""${NC}"
if ! docker pull "${CONTAINER}"; then
echo -e "${RED}""Failed to download ${CONTAINER}.""${NC}"
echo -e "${ORANGE}""Checking if we have any usable local images...""${NC}"
# Check if there are any embeddedanalyzer/emba images
if ! docker images | grep -q "embeddedanalyzer/emba"; then
echo -e "${RED}""No local EMBA images found. Installation may be incomplete.""${NC}"
read -p "Press any key to continue anyway..." -n1 -s -r
else
echo -e "${GREEN}""Found alternative local EMBA image, will use that instead.""${NC}"
# Use the latest local EMBA image
LOCAL_IMAGE=$(docker images embeddedanalyzer/emba --format "{{.Repository}}:{{.Tag}}" | head -1)
CONTAINER="${LOCAL_IMAGE}"
fi
fi
fi
# Make sure the image has the latest label
docker tag "${CONTAINER}" "${CONTAINER/:*}:latest"
sed -i "/image:/c\ image: ${CONTAINER}" docker-compose.yml
export DOCKER_CLI_EXPERIMENTAL=disabled
"${DOCKER_COMPOSE[@]}" up --no-start
else
echo "Estimated download-Size: ~5500 MB"
echo -e "${ORANGE}""WARNING: docker command missing - no docker pull possible.""${NC}"
fi
;;
esac
fi
}
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Priority issue
Are you already a Sponsor? - [Y/N] N
Additional context
Add any other context or screenshots about the feature request here.
English is not my native language; please excuse typing errors.