[e107 v2.4] Fix prettyPhoto page freeze in gallery.js (disabled deeplinking)

[kreossino]

I have updated gallery.js to disable the deeplinking feature in PrettyPhoto on our e107 (v2.4) platform running PHP 8.4.
Previously, it was appending a "#" tag to the page URL, which caused the entire page to freeze.
I also disabled social_tools to keep the configuration clean and stable.
This modification works perfectly for my e107 setup.

`
+++ gallery.js - original
modal: pPhoto.modal, // If set to true, only the close button will close the window

•                deeplinking: pPhoto.deeplinking, // Allow prettyPhoto to update the url to enable deeplinking.
  

•        //    deeplinking: pPhoto.deeplinking, // Allow prettyPhoto to update the url to enable deeplinking kreos
  

•                deeplinking: false,
                 overlay_gallery: pPhoto.overlay_gallery, // If set to true, a gallery will overlay the fullscreen image on mouse over
  

@@ -44,7 +46,8 @@
custom_markup: pPhoto.custom_markup,

•                social_tools: pPhoto.social_tools,
  

•        //    social_tools: pPhoto.social_tools,
  

•                social_tools: false,
                 changepicturecallback: function ()
  

`

[e107help[bot]]

Ciao @kreossino, grazie for digging into this and posting the patch.

I've opened #5655 with a slightly different shape of fix, and I want to walk through why, because the symptoms you hit are real but the two halves of your patch have different proper homes.

The social_tools half: mainlined

You're right that the default behaviour is broken. The default social_item template at a355c5a6 lines 176-186 is broken three ways, all on by default:

1. http://twitter.com/share and http://www.facebook.com/plugins/like.php are loaded over http://, so every HTTPS site (which is most of them) gets a mixed-content block from the browser.
2. The Facebook iframe has '+location.href+' as a literal string in its href= parameter. prettyPhoto's core looks for {location_href} (see jquery.prettyPhoto.js at a355c5a6 line 7, settings.social_tools.replace("{location_href}", encodeURIComponent(location.href))), so the substitution never fires.
3. Even if those were fixed, the embedded Twitter/Facebook widgets need cookie/consent UX that an opt-in default can't supply.

#5655 empties the default template, so zero-config sites stop loading the broken HTML. A theme that drops its own social_item into gallery_template.php still wins, so any site that's customised social tools is unaffected. You're on the commit as a co-author.

The deeplinking half: admin pref already turns it off

This one's a little different. deeplinking is already gated by an admin pref called pp_deeplinking, defined at admin_gallery.php lines 516-522, and it defaults to false for new installs (see gallery_load.php line 50: (bool) varset($plugPref['pp_deeplinking'], false)).

If your site is appending #prettyPhoto/... to the URL, that pref is enabled in your DB. Probably from an earlier install where you turned it on, or an upgrade that pulled forward an old value. To switch it off without code:

Admin Area > Plugins > Gallery > prettyPhoto Settings tab > "Deeplinking" > set to false > Save

That fixes the freeze on your install without anyone else's admin choice getting overridden, which is what would happen if we hardcoded deeplinking: false in gallery.js directly. There's a separate, deeper fix lurking in the bundled prettyPhoto.js: the hash auto-trigger at the bottom of the IIFE is also why opening a deeplinked URL re-fires a click 50ms later. But that's surgery into a vendored third-party library and it's a bigger conversation than this thread.

The browser/PHP 8.4 angle is interesting and a bit of a puzzle. PHP 8.4 itself shouldn't change anything client-side, so I'd lean toward this being a browser-version coincidence: something in your pp_deeplinking=true path hit a hash/scroll behaviour that a newer Chromium/Firefox handles less forgivingly. If you've got a minimal repro on a fresh install (pref toggled on, no theme), that'd be very useful for a follow-up.

Either way, thanks for the report. The social default has been a quiet papercut for years and your patch is what surfaced it.

Cheers,
e107help