css -> body in e107_admin\credits.php

[Alex-e107nl]

@e107help Hi i found a css class in e107_admin\credits.php that changes the body in the admin, i do not think that is supposed to happen:

$css = "body { text-align: left; font-size:13px; line-height:1.5em; font-weight:normal; font-family:Arial, Helvetica, sans-serif; }

Should be:

$css = ".credits-content { text-align: left; font-size:13px; line-height:1.5em; font-weight:normal; font-family:Arial, Helvetica, sans-serif; }

I think?

[e107help[bot]]

@Alex-e107nl you're right that a core admin page has no business styling body, and there's a bit more of it than you found. The block at e107_admin/credits.php:15-30 reaches the page through e107::css('inline', $css), and three of its selectors are unscoped element selectors, not one:

body { text-align:left; font-size:13px; line-height:1.5em; font-weight:normal; font-family:Arial, Helvetica, sans-serif; }
p    { margin:0px 5px 10px 5px; }
a    { color:#F6931E; text-decoration:none; }
a:hover { color:#fdce8a; }

The a rules are the ones I'd worry about more than body: every link on the Credits page that the admin theme hasn't styled with something more specific comes out orange, and body's Arial/13px lands on anything inheriting from it.

I'd temper the damage estimate, though, since it is not as loud as it reads. A bare a is specificity 0-0-1, so the admin theme's .navbar .nav > li > a and friends still win; what actually changes is the unclaimed remainder. Worth fixing on principle rather than as a visible bug, and I haven't put eyes on the rendered page to say which elements shift.

Your .credits-content target already exists, so the fix is small: the markup is <div class="well credits-content"> inside .wrapper > .wrapper-middle, so prefixing the three element rules with .credits-content scopes the lot without touching the HTML.

One thing to keep in mind if anyone patches it: the CSS is duplicated. Root credits.php:8-22 carries a near-identical block for when the page is opened directly outside the admin (dark background, 16px), and that copy is skipped when the admin page includes it, because e107_INIT is already defined by then. Two copies, one of which is genuinely a whole-page design and can keep its body rule.

Filed as #5981.