No placeholder when using only login name to login...

[Alex-e107nl]

@e107help In e107_plugins/signin/signin_shortcodes.php you find this code:

	function __construct()
	{
		$pref = e107::getPref();

		$this->use_imagecode = e107::getConfig()->get('logcode');
		$this->usernamePlaceholder = '';
		$this->allowEmailLogin = $pref['allowEmailLogin'];

		if ($pref['allowEmailLogin'] == 1)
		{
			$this->usernamePlaceholder = LAN_LOGINMENU_49;
		}

		if ($pref['allowEmailLogin'] == 2)
		{
			$this->usernamePlaceholder = LAN_LOGINMENU_50;
		}

		$this->regMode = (int) defset('USER_REGISTRATION');

		$this->authMethod = vartrue($pref['auth_method'], 'e107');

	}

But when i change it to:

	function __construct()
	{

		$pref = e107::getPref();

		$this->use_imagecode = e107::getConfig()->get('logcode');
		$this->usernamePlaceholder = '';
		$this->allowEmailLogin = $pref['allowEmailLogin'];

		if ($pref['allowEmailLogin'] == 0)
		{
			$this->usernamePlaceholder = LAN_LOGINMENU_1;
		}
		if ($pref['allowEmailLogin'] == 1)
		{
			$this->usernamePlaceholder = LAN_LOGINMENU_49;
		}

		if ($pref['allowEmailLogin'] == 2)
		{
			$this->usernamePlaceholder = LAN_LOGINMENU_50;
		}

		$this->regMode = (int) defset('USER_REGISTRATION');

		$this->authMethod = vartrue($pref['auth_method'], 'e107');

	}

Without this it shows no 'username' in the input field, i get this after the edit:

[e107help[bot]]

@Alex-e107nl Delete a line rather than add one. The culprit is signin_shortcodes.php:39, $this->usernamePlaceholder = '';, three lines above the block you pasted. The property is already declared as LAN_LOGINMENU_1 at :28 and the constructor throws that away before anything can read it, then refills it only for 1 and 2. Deleting it gives you the screen in your screenshot and also covers a site where the pref is missing altogether, which your == 0 branch does not.

The same line sits in the login menu at login_menu_shortcodes.php:54, so if you show that menu it has the same empty caption on the same setting. Its {LM_USERNAME_LABEL} comes back empty too.

That deletion is what is in the two pull requests, #6120 for master and #6122 for release/v2.3.x. Whether and when either merges is Deltik's call rather than mine.

One consequence of the deletion, which is the reason it is worth mentioning at all. At setting 0 the placeholder is empty today, so no translated string reaches it; deleting that line is what starts writing LAN_LOGINMENU_1 into placeholder='...', between single quotes. If your language pack's word for Username carries an apostrophe, it will close that attribute early and the input will lose required, id, size and maxlength. The English pack has no apostrophe there, and neither does the value you are running. I left the cure out on purpose: passing the caption through toAttribute() returns an empty string for a language file byte that is not valid UTF-8, so it would blank the caption on settings 1 and 2, which work today. It wants its own change.

Thanks for finding the constructor yourself and pasting it with the screenshot. That is most of the diagnosis done before I started.