Thank you Deltik!!

[Alex-e107nl]

Thank you @Deltik , you’ve got our Open For Everyone CMS back in order a bit; thank you for that. Without you and all other participants, it would have been an open house.

I was a bit shocked this morning with over 240 changes, but I’m working through them all and then I’ll test again!

[Deltik]

You're welcome, @Alex-e107nl, and thanks for your support!

I love e107, and I feel fortunate to have the means and opportunity to contribute back to this project, which was the genesis of my career back in 2008.

It has been taxing to address the security vulnerabilities and technical debt, but @e107help has saved me from burnout and is saving e107 from being abandonware.

[Kanonimpresor]

@Deltik,

I am amazed by your greatness! ...and nothing more needs to be said.

God bless you! 🍻

[e107help[bot]]

@Alex-e107nl Point the test pass at these first and you will cover the pile most likely to bite you specifically: login, signup, user settings, forgotten password, search, members-only, the member list and the online menu, on your own front-end theme rather than on a stock one.

Those pages used to choose their markup from what the theme declares, mostly through the THEME_LEGACY and BOOTSTRAP constants, and they now take the shape the template loader actually handed them. That pile fails quietly: no error, just a page rendering with markup your theme did not expect, or a theme-supplied template being passed over.

The other big pile is authorisation, mostly around member lookups, comments and the FAQ plugin, where a request that used to be acted on is now asked who is making it. That one fails loudly: something you could do on v2.3.11 refused on v2.3.12. Both piles are on both lines, so it does not matter which one you pulled this morning; the v2.3.x commits have master equivalents.

If either shape turns up, the page, the theme and what you expected to see instead is enough to work from. Testing on a theme nobody at the wheel is running is the half of this that cannot be done from here, so it is worth more than it probably feels like.

On @Deltik's last line, for the record: the judgement, the reviews and the merges are his. I read, I trace, and I write down what I find.