Conversation
43081j
approved these changes
Apr 14, 2026
Comment on lines
+72
to
+73
| "description": "You can use `crypto.randomBytes` with `Buffer.prototype.toString` to generate a random base64 id", | ||
| "example": "import crypto from 'node:crypto'\nconst id = crypto.randomBytes(15).toString('base64').replaceAll('+', '-').replaceAll('/', '_')" |
Contributor
There was a problem hiding this comment.
sorry for the late comment but we should probably recommend Uint8Array over Buffer due to it being a built-in javascript feature, now that it has base64 support
sindre has a blog post that goes in depth about this topic: https://sindresorhus.com/blog/goodbye-nodejs-buffer
example with Uint8Array + web crypto api (no imports needed):
crypto.getRandomValues(new Uint8Array(15)).toBase64();
Contributor
Author
There was a problem hiding this comment.
Since the original package also uses node:crypto module I decided to keep it simple
Contributor
There was a problem hiding this comment.
can one of you open an issue so we can look into it?
i think you may be right and we should just use uint8arrays but lets track it in a new issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Closes #552
📚 Description
add
base64idto replacements