Skip to content

chore(cli): remove unused dockerfile-ast dependency - #1509

Merged
mishushakov merged 1 commit into
mainfrom
mishushakov/find-unused-imports
Jun 30, 2026
Merged

chore(cli): remove unused dockerfile-ast dependency#1509
mishushakov merged 1 commit into
mainfrom
mishushakov/find-unused-imports

Conversation

@mishushakov

Copy link
Copy Markdown
Member

The CLI declared dockerfile-ast as a dependency but never imported it — all Dockerfile parsing in the CLI goes through the e2b SDK, which keeps its own (newer) dockerfile-ast dependency. This drops the redundant copy from packages/cli/package.json, removing dockerfile-ast@0.6.1 and its sub-deps from the lockfile while dockerfile-ast@0.7.1 (used by the js-sdk) stays. No behavior change; CLI typecheck and lint pass, and a @e2b/cli patch changeset is included.

🤖 Generated with Claude Code

The CLI declared dockerfile-ast but never imported it — all Dockerfile
parsing goes through the e2b SDK, which keeps its own dockerfile-ast
dependency. Drop the redundant (and older-pinned) copy.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e03ddf7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@e2b/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cursor

cursor Bot commented Jun 30, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Dependency cleanup only with no code path changes; Dockerfile parsing remains on the SDK.

Overview
Removes the unused dockerfile-ast entry from @e2b/cli dependencies and updates the lockfile so dockerfile-ast@0.6.1 is no longer installed for the CLI. Dockerfile parsing still goes through the e2b SDK, which retains its own dockerfile-ast@0.7.1 dependency.

Includes a @e2b/cli patch changes.changeset**; no runtime or CLI behavior change.

Reviewed by Cursor Bugbot for commit e03ddf7. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

Package Artifacts

Built from ca7f469. Download artifacts from this workflow run.

JS SDK (e2b@2.31.1-mishushakov-find-unused-imports.0):

npm install ./e2b-2.31.1-mishushakov-find-unused-imports.0.tgz

CLI (@e2b/cli@2.13.1-mishushakov-find-unused-imports.0):

npm install ./e2b-cli-2.13.1-mishushakov-find-unused-imports.0.tgz

Python SDK (e2b==2.30.0+mishushakov-find-unused-imports):

pip install ./e2b-2.30.0+mishushakov.find.unused.imports-py3-none-any.whl

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — verified no dockerfile-ast imports remain in packages/cli.

Extended reasoning...

Overview

This PR removes the unused dockerfile-ast@^0.6.1 dependency from packages/cli/package.json and updates pnpm-lock.yaml accordingly. A @e2b/cli patch changeset is included. The SDK package still pulls in its own dockerfile-ast@0.7.1, which is what the CLI's Dockerfile-parsing code paths transitively rely on.

Security risks

None. This is a pure dependency removal — no code paths are touched, no auth/crypto/permissions surface is involved. Removing an unused dependency slightly reduces supply-chain surface area.

Level of scrutiny

Minimal scrutiny needed. I grepped packages/cli for any reference to dockerfile-ast and got zero hits, confirming the dependency was truly unused. The lockfile delta is consistent with removing only the 0.6.1 entry while leaving 0.7.1 (used by the e2b SDK) intact.

Other factors

The bug-hunting system found nothing. A changeset is included for the version bump. CLI typecheck/lint pass per the PR description, and this is exactly the kind of mechanical cleanup that fits the auto-approve criteria.

@mishushakov
mishushakov enabled auto-merge (squash) June 30, 2026 11:04
@mishushakov
mishushakov requested a review from huv1k June 30, 2026 11:27
@mishushakov
mishushakov merged commit 9b4a743 into main Jun 30, 2026
30 of 31 checks passed
@mishushakov
mishushakov deleted the mishushakov/find-unused-imports branch June 30, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants