chore(cli): remove unused dockerfile-ast dependency - #1509
Conversation
The CLI declared dockerfile-ast but never imported it — all Dockerfile parsing goes through the e2b SDK, which keeps its own dockerfile-ast dependency. Drop the redundant (and older-pinned) copy. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: e03ddf7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
PR SummaryLow Risk Overview Includes a Reviewed by Cursor Bugbot for commit e03ddf7. Bugbot is set up for automated code reviews on this repo. Configure here. |
Package ArtifactsBuilt from ca7f469. Download artifacts from this workflow run. JS SDK ( npm install ./e2b-2.31.1-mishushakov-find-unused-imports.0.tgzCLI ( npm install ./e2b-cli-2.13.1-mishushakov-find-unused-imports.0.tgzPython SDK ( pip install ./e2b-2.30.0+mishushakov.find.unused.imports-py3-none-any.whl |
There was a problem hiding this comment.
LGTM — verified no dockerfile-ast imports remain in packages/cli.
Extended reasoning...
Overview
This PR removes the unused dockerfile-ast@^0.6.1 dependency from packages/cli/package.json and updates pnpm-lock.yaml accordingly. A @e2b/cli patch changeset is included. The SDK package still pulls in its own dockerfile-ast@0.7.1, which is what the CLI's Dockerfile-parsing code paths transitively rely on.
Security risks
None. This is a pure dependency removal — no code paths are touched, no auth/crypto/permissions surface is involved. Removing an unused dependency slightly reduces supply-chain surface area.
Level of scrutiny
Minimal scrutiny needed. I grepped packages/cli for any reference to dockerfile-ast and got zero hits, confirming the dependency was truly unused. The lockfile delta is consistent with removing only the 0.6.1 entry while leaving 0.7.1 (used by the e2b SDK) intact.
Other factors
The bug-hunting system found nothing. A changeset is included for the version bump. CLI typecheck/lint pass per the PR description, and this is exactly the kind of mechanical cleanup that fits the auto-approve criteria.
The CLI declared
dockerfile-astas a dependency but never imported it — all Dockerfile parsing in the CLI goes through thee2bSDK, which keeps its own (newer)dockerfile-astdependency. This drops the redundant copy frompackages/cli/package.json, removingdockerfile-ast@0.6.1and its sub-deps from the lockfile whiledockerfile-ast@0.7.1(used by the js-sdk) stays. No behavior change; CLI typecheck and lint pass, and a@e2b/clipatch changeset is included.🤖 Generated with Claude Code