fix(cli): bump @npmcli/package-json to ^7, clearing deprecated glob@10 - #1614
Conversation
🦋 Changeset detectedLatest commit: 306529b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit 306529b. Bugbot is set up for automated code reviews on this repo. Configure here. |
Package ArtifactsBuilt from 2c1c7c3. Download artifacts from this workflow run. JS SDK ( npm install ./e2b-2.36.1-cli-bump-node-22-version.0.tgzCLI ( npm install ./e2b-cli-2.15.2-cli-bump-node-22-version.0.tgzPython SDK ( pip install ./e2b-2.35.0+cli.bump.node.22.version-py3-none-any.whl |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 06a7d6fa72
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
`@npmcli/package-json@5` pins `glob@10`, which is deprecated on npm, so every `npm install @e2b/cli` printed a `npm warn deprecated glob@10.5.0` warning. This was called out as "not fixed here" in #1613, which cleared the matching `glob@11` warning in `e2b`. `^7.0.5` is the floor that actually fixes it: 7.0.0-7.0.2 still depend on `glob@^11` (also deprecated), and the move to `glob@13` only landed in 7.0.4. `@npmcli/package-json@7` requires Node `^20.17.0 || >=22.9.0`, so the CLI's Node 22 floor moves from `>=22` to `>=22.9.0` -- matching the dependency exactly rather than excluding anyone it still supports. Node 20 support is unchanged, since `^20.17.0` covers the existing `>=20.18.1 <21`. Co-Authored-By: Claude <noreply@anthropic.com>
06a7d6f to
306529b
Compare
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
2 participants
Follow-up to #1613, which fixed the
glob@11deprecation warning ine2bbut left@e2b/cliwarning via@npmcli/package-json@5 → glob@10. That PR proposed@npmcli/package-json@7, but^7alone isn't enough — 7.0.0–7.0.2 still depend on the equally deprecatedglob@^11, and the move toglob@13only landed in 7.0.4, so this pins^7.0.5. Since@npmcli/package-json@7requires Node^20.17.0 || >=22.9.0, the CLI's Node 22 floor moves from>=22to>=22.9.0— matching the dependency exactly rather than excluding anyone it still supports. Node 20 support is unchanged, since^20.17.0covers the existing>=20.18.1 <21.Before / after
No API change.
e2b template initis the only consumer, and thePackageJson.load/create/update/savesurface it uses is unchanged across the bump.Verification
e2b+@e2b/cliand installed into a scratch project withoverridespointinge2bat the local tarball (the post-release state): zero deprecation warnings,npm ls glob --allreports onlyglob@13.0.6.e2b template init -n my-tmpl -l typescriptfrom that packed install against a real hostpackage.json— scripts added, pre-existing scripts preserved.packages/clisuite: 102 passed / 1 skipped, including all 14template inittests, which assert on the writtenpackage.jsonin both theload(existing file) andcreate(no file) branches.template/create.test.tsfails identically on a clean tree in this environment — it requiresE2B_API_KEY.pnpm run format/lint/typecheckclean.@types/npmcli__package-jsonstays at^4.0.4; v7 ships no types..tool-versionsis untouched: the pinnednodejs 22.18.0already satisfies>=22.9.0, so CI (which derivesnode-versionfrom that file) needs no change.Closes SDK-297. Follow-up to #1613 (SDK-296).
🤖 Generated with Claude Code