Rename teams to projects in user-visible dashboard copy - #516
Merged
Conversation
Words-only rename (first PR of the Teams → Projects stack): switcher, sidebar, General, Members, API Keys, create dialog, blocked flow, errors, toasts, aria-labels, and the default-name transform (X's Project / Personal Project). Adds a dismissible announcement banner linking to the projects docs. Machine contracts (slugs, cookies, headers, tRPC/API names, analytics) are deliberately unchanged.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
auth.setup.ts silently persists an unauthenticated storage state when the Ory hosted UI rejects the runner with a captcha, so authed navigation bounces to /sign-in and timed out. Detect the bounce and skip with an explicit reason; assertions still run whenever the session is real (local dev mode, or CI once a captcha bypass exists for the test user).
The previous guard only recognized a /sign-in URL, but an unauthenticated /dashboard visit redirect-chains to the Ory hosted login on a different origin, so the wait still timed out. Wait for the team-scoped URL with a bounded deadline instead and skip (with the landing URL in the reason) when it never arrives.
It asserted static copy literals already covered by unit tests, and the authed CI session is captcha-blocked so it only ever skipped in the pipeline. E2E coverage should return with real user flows once the CI test user can bypass the captcha.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PROJECT, "Create new project"), sidebar group heading, General (project id, aria-labels, Zod messages, toasts), Members, create dialog, the full blocked flow, billing plan note, error strings, and empty states.X's Project(orPersonal Projectwhen no name is derivable) — same rule PR 2's provisioning uses.TeamNameSchemaaccepts apostrophes so generated names survive an edit round-trip.Testing
520 unit tests (vitest) incl. new transform/schema/banner suites and targeted render tests for the blocked-flow dialogs; unfiltered case-insensitive copy sweep with every remaining hit triaged. (A Playwright smoke spec was added and then dropped: it only asserted static copy literals already unit-covered, and the authed CI session is captcha-blocked, so it could never execute in the pipeline.)
Interim states (known, time-boxed): until PR 2, new signups still get "Default Team" names under
PROJECTlabels; until PR 3, existing stored names render as-is exceptname == emailrows.Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.