Skip to content

chore: stop populating logs status field for v2 builds#1376

Merged
dobrac merged 3 commits into
mainfrom
stop-populating-logs-field-for-v2-builds-eng-3197
Oct 20, 2025
Merged

chore: stop populating logs status field for v2 builds#1376
dobrac merged 3 commits into
mainfrom
stop-populating-logs-field-for-v2-builds-eng-3197

Conversation

@dobrac

@dobrac dobrac commented Oct 18, 2025

Copy link
Copy Markdown
Contributor

Stop populating logs status field for v2 builds. Saves also the builder version to the database to be able to correctly distinguish.


Note

Persist build version for templates, return legacy text logs only for < v2, and update API, DB, models, and orchestrator to be version-aware.

  • API:
    • Build status endpoint: returns legacy result.Logs only when build version < templates.TemplateV2BetaVersion; always returns structured LogEntries.
    • Build requests: set build version (v1 for v1 endpoint, latest v2 for v2 endpoint); add version to telemetry and cache status logs.
    • Template/build caches: include build version in TemplateBuildInfo and logs.
  • DB/Models:
    • Migration: add nullable version column to public.env_builds.
    • Queries: select/scan version; update status query sets version.
    • Ent/sqlc models: add version field with create/update/upsert and predicates.
  • Orchestrator:
    • Gate default user/workdir phases on TemplateV2ReleaseVersion (was TemplateDefaultUserVersion).
  • Utils:
    • Add DerefOrDefault, IsSmallerVersion; version constants updated (TemplateV2ReleaseVersion).
  • Tests/Infra:
    • Seed: set version for builds; interfaces asserted for template manager and tests.

Written by Cursor Bugbot for commit c5833db. This will update automatically on new commits. Configure here.

@linear

linear Bot commented Oct 18, 2025

Copy link
Copy Markdown

@dobrac dobrac added the improvement Improvement for current functionality label Oct 18, 2025
@dobrac dobrac marked this pull request as ready for review October 18, 2025 09:39
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@sitole sitole assigned sitole and unassigned jakubno Oct 20, 2025
@sitole sitole self-requested a review October 20, 2025 09:00
@dobrac dobrac merged commit 38021c2 into main Oct 20, 2025
27 checks passed
@dobrac dobrac deleted the stop-populating-logs-field-for-v2-builds-eng-3197 branch October 20, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement for current functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants