Skip to content

feat(orchestrator): LD-gated ClickHouse write fan-out feature flag#3152

Merged
rguliyev merged 2 commits into
mainfrom
feat/clickhouse-write-fanout-ld-gate
Jul 1, 2026
Merged

feat(orchestrator): LD-gated ClickHouse write fan-out feature flag#3152
rguliyev merged 2 commits into
mainfrom
feat/clickhouse-write-fanout-ld-gate

Conversation

@rguliyev

@rguliyev rguliyev commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Add ClickhouseWriteFanoutFlag (defaults false);
flipping it true in LD enables writes to additional ClickHouse endpoints without a redeploy.
Default DSN writes are never gated.

Add ClickhouseWriteFanoutFlag (defaults false); flipping it true in LD
enables writes to additional ClickHouse endpoints without a redeploy.
Default DSN writes are never gated.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces gated ClickHouse delivery wrappers (GatedClickhouseDelivery) for events and host stats, controlled by a new feature flag ClickhouseWriteFanoutFlag to conditionally drop writes to alternate ClickHouse endpoints. No review comments were provided, and there is no additional feedback.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
3125 2 3123 6
View the top 2 failed test(s) by shortest run time
github.com/e2b-dev/infra/tests/integration/internal/tests/proxies::TestMaskRequestHostAPIParameter
Stack Traces | 4.76s run time
=== RUN   TestMaskRequestHostAPIParameter
=== PAUSE TestMaskRequestHostAPIParameter
=== CONT  TestMaskRequestHostAPIParameter
    mask_request_host_test.go:44: Command [python3] output: event:{start:{pid:1114}}
    mask_request_host_test.go:68: Command [cat] output: event:{start:{pid:1115}}
    mask_request_host_test.go:68: Command [cat] output: event:{data:{stderr:"cat: /tmp/nc_output.txt: No such file or directory\n"}}
    mask_request_host_test.go:68: Command [cat] output: event:{end:{exit_code:1 exited:true status:"exit status 1" error:"exit status 1"}}
    mask_request_host_test.go:69: 
        	Error Trace:	.../tests/proxies/mask_request_host_test.go:69
        	Error:      	Received unexpected error:
        	            	command cat in sandbox i9hwd6eze8yl3rtnsml2m failed with exit code 1
        	Test:       	TestMaskRequestHostAPIParameter
--- FAIL: TestMaskRequestHostAPIParameter (4.76s)
github.com/e2b-dev/infra/tests/integration/internal/tests/envd::TestCommandKillNextApp
Stack Traces | 266s run time
=== RUN   TestCommandKillNextApp
=== PAUSE TestCommandKillNextApp
=== CONT  TestCommandKillNextApp
Executing command /bin/bash in sandbox izhhetcxhw4ci9wfswsz2
    process_test.go:30: Build failed: {<nil> build was cancelled <nil>}
--- FAIL: TestCommandKillNextApp (266.43s)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Comment thread packages/clickhouse/pkg/hoststats/delivery.go
@rguliyev rguliyev merged commit f046fcf into main Jul 1, 2026
53 checks passed
@rguliyev rguliyev deleted the feat/clickhouse-write-fanout-ld-gate branch July 1, 2026 03:39
charlie-e2b pushed a commit that referenced this pull request Jul 7, 2026
🤖 I have created a release *beep* *boop*
---


## 1.0.0 (2026-07-07)


### Features

* Adding client-proxy and clickhouse to e2b-artifacts
([#3210](#3210))
([5686d88](5686d88))
* **api:** LD-gated ClickHouse read switcher
([#3061](#3061))
([29e74ca](29e74ca))
* **clickhouse:** implement multi-cluster fan-out for events and stats
([#2925](#2925))
([39594c6](39594c6))
* **migrations:** add webhook deliveries table to ClickHouse
([#2741](#2741))
([f55a5bd](f55a5bd))
* **orchestrator:** LD-gated ClickHouse write fan-out feature flag
([#3152](#3152))
([f046fcf](f046fcf))
* **orch:** re-enable memory.peak per-FD reset (cgroups v2)
([#2430](#2430))
([5d9ac5f](5d9ac5f))
* per-team events TTL limit (tier + addons)
([#3181](#3181))
([f76b2cb](f76b2cb))


### Bug Fixes

* push clickhouse-migrator image to both latest and commit SHA tags
([#2954](#2954))
([3b780d5](3b780d5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: e2b-release-please[bot] <298072688+e2b-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants