Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
==========================================
- Coverage 63.15% 62.24% -0.91%
==========================================
Files 32 33 +1
Lines 1900 2633 +733
Branches 204 315 +111
==========================================
+ Hits 1200 1639 +439
- Misses 600 828 +228
- Partials 100 166 +66 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| switch (hash_algorithm) { | ||
| case HashAlgorithm::NONE: | ||
| return true; | ||
| case HashAlgorithm::CRC32: { |
There was a problem hiding this comment.
we should use the same hash_algorithm between valid and seal , right?
seal is now always using crc32, so other hash_algorithm does not make sense to valid.
I mean can we add a member to indicate the hash_algorithm, and valid and seal will share it
There was a problem hiding this comment.
Good catch, will fix in the next push.
There was a problem hiding this comment.
Implement CRC32 hash integrity check for BlobHeader to prevent crashes caused by faults in critical fields (size/algorithm...).
Implement CRC32 hash integrity check for BlobHeader to prevent crashes caused by faults in critical fields (size/algorithm...).